From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Tuomas Tynkkynen
<ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] clk: tegra: Fix wrong value written to PLLE_AUX
Date: Sat, 17 May 2014 23:06:59 +0200 [thread overview]
Message-ID: <20140517210657.GB1046@mithrandir> (raw)
In-Reply-To: <5376373E.1080401-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
On Fri, May 16, 2014 at 10:05:18AM -0600, Stephen Warren wrote:
> On 05/16/2014 08:31 AM, Thierry Reding wrote:
> > On Fri, May 16, 2014 at 04:50:20PM +0300, Tuomas Tynkkynen wrote:
> >> The value written to PLLE_AUX was incorrect due to a wrong variable
> >> being used.
> >>
> >> Signed-off-by: Tuomas Tynkkynen <ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >> Tested-by: Mikko Perttunen <mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >> ---
> >> This fix is required for the (upcoming) SATA support.
> >> drivers/clk/tegra/clk-pll.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > Tested-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > Mike, Peter, it might be good to have this go into 3.16 as a
> > prerequisite for the upcoming SATA driver (which presumably won't be
> > ready until 3.17, but in that case it would be good to have this
> > prerequisite merged already).
>
> Probably even Cc: stable since it's a fix for a bug that I assume has
> been in a kernel release or two?
Yeah, I guess that makes sense. The bug isn't visible yet, but back-
porting to stable might save somebody else from chasing this if they
ever decide to backport PCIe, SATA or XUSB.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-17 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 13:50 [PATCH] clk: tegra: Fix wrong value written to PLLE_AUX Tuomas Tynkkynen
[not found] ` <1400248220-16025-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-05-16 14:31 ` Thierry Reding
2014-05-16 16:05 ` Stephen Warren
[not found] ` <5376373E.1080401-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-17 21:06 ` Thierry Reding [this message]
2014-05-19 8:45 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140517210657.GB1046@mithrandir \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox