* [patch] drm/tegra: sor - missing unlock on error
@ 2014-06-11 7:06 Dan Carpenter
2014-07-14 6:53 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-06-11 7:06 UTC (permalink / raw)
To: Thierry Reding
Cc: Terje Bergström, Stephen Warren, kernel-janitors, dri-devel,
linux-tegra, Rob Herring, Grant Likely
We should unlock before returning the error code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 27c979b..64f57fa 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -516,7 +516,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
if (err < 0) {
dev_err(sor->dev, "failed to probe eDP link: %d\n",
err);
- return err;
+ goto unlock;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] drm/tegra: sor - missing unlock on error
2014-06-11 7:06 [patch] drm/tegra: sor - missing unlock on error Dan Carpenter
@ 2014-07-14 6:53 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2014-07-14 6:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: Terje Bergström, Stephen Warren, kernel-janitors, dri-devel,
linux-tegra, Rob Herring, Grant Likely
[-- Attachment #1.1: Type: text/plain, Size: 636 bytes --]
On Wed, Jun 11, 2014 at 10:06:09AM +0300, Dan Carpenter wrote:
> We should unlock before returning the error code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> index 27c979b..64f57fa 100644
> --- a/drivers/gpu/drm/tegra/sor.c
> +++ b/drivers/gpu/drm/tegra/sor.c
> @@ -516,7 +516,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
> if (err < 0) {
> dev_err(sor->dev, "failed to probe eDP link: %d\n",
> err);
> - return err;
> + goto unlock;
> }
> }
>
Applied, thanks.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-14 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-11 7:06 [patch] drm/tegra: sor - missing unlock on error Dan Carpenter
2014-07-14 6:53 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).