Re: [PATCH 3/4] drm/tegra: Add SET/GET_FLAGS IOCTLs

Thierry Reding
2014-06-12T07:18:40Z

[-- Attachment #1.1: Type: text/plain, Size: 2509 bytes --]

On Wed, Jun 11, 2014 at 09:21:21AM -0700, Stéphane Marchesin wrote:
> On Tue, Jun 10, 2014 at 4:04 AM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The DRM_TEGRA_GEM_SET_FLAGS IOCTL can be used to set the flags of a
> > buffer object after it has been allocated or imported. Flags associated
> > with a buffer object can be queried using the DRM_TEGRA_GEM_GET_FLAGS
> > IOCTL.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/gpu/drm/tegra/drm.c | 48 ++++++++++++++++++++++++++++++++++++++++++++
> > include/uapi/drm/tegra_drm.h | 21 +++++++++++++++++++
> > 2 files changed, 69 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
> > index 5dca20982f3b..f292c29ef62f 100644
> > --- a/drivers/gpu/drm/tegra/drm.c
> > +++ b/drivers/gpu/drm/tegra/drm.c
> > @@ -548,6 +548,52 @@ static int tegra_gem_get_tiling(struct drm_device *drm, void *data,
> >
> > return err;
> > }
> > +
> > +static int tegra_gem_set_flags(struct drm_device *drm, void *data,
> > + struct drm_file *file)
> > +{
> > + struct drm_tegra_gem_set_flags *args = data;
> > + struct drm_tegra_bo *bo;
> > + unsigned long flags = 0;
> > +
> > + if (args->flags & ~DRM_TEGRA_GEM_FLAGS)
> > + return -EINVAL;
> > +
> > + gem = drm_gem_object_lookup(drm, file, args->handle);
> > + if (!gem)
> > + return -EINVAL;
>
> Usually -ENOENT is returned for unknown objects I think?

We've had that discussion on IRC a little while back. I came across a
few places where this was returned to userspace, and since I remember
a particular email[0] about this error code so well I thought it should
be discussed, but I can't remember the outcome (if any). Quoting from
that email:

ENOENT is not a valid error return from an ioctl. Never has been,
never will be. ENOENT means "No such file and directory", and is
for path operations. ioctl's are done on files that have already
been opened, there's no way in hell that ENOENT would ever be
valid.

Given that -ENOENT is used *a lot* in DRM (many, if not most, of the
instances returning the error from an IOCTL), I wonder how this can be
resolved. Given that userspace may rely on this error code and that we
can't break userspace I don't see a way out.

Thierry

[0]: https://lkml.org/lkml/2012/12/23/75

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org