From: Mark Brown <broonie@kernel.org>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: tegra: TN7: relax some regulators
Date: Fri, 20 Jun 2014 11:16:18 +0100 [thread overview]
Message-ID: <20140620101618.GU5099@sirena.org.uk> (raw)
In-Reply-To: <53A3C613.8030207@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On Fri, Jun 20, 2014 at 02:26:43PM +0900, Alexandre Courbot wrote:
> So I can see three questions here:
> 1) Why does _regulator_enable() on vdd_1v8 return 0 while everything
> suggests that it is enabled (this regulator powers lot of devices, like
> eMMC, which are working fine). This may be an issue with the palmas driver.
Returning 0 is reporting success and you say it is enabled so I'm not
seeing any contradiction here... or do you mean regulator_is_enabled()
here? An always on regulator should report that it is enabled.
> 2) When an always-on regulator that is not yet enabled is registered,
> shouldn't it be switched on by the regulator framework?
This happens during set_machine_constraints().
> 3) When a boot-on regulator is registered and _regulator_is_enabled()
> returns contradictory information, what should be done?
Same thing here (same check even).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-20 10:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 7:49 [PATCH] ARM: tegra: TN7: relax some regulators Alexandre Courbot
2014-06-19 15:59 ` Stephen Warren
2014-06-19 17:56 ` Mark Brown
[not found] ` <20140619175643.GR5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-20 5:26 ` Alexandre Courbot
[not found] ` <53A3C613.8030207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-20 6:44 ` Alexandre Courbot
[not found] ` <53A3D85E.7030704-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-20 9:41 ` Mark Brown
[not found] ` <20140620094119.GT5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-20 9:49 ` Alexandre Courbot
2014-06-20 13:23 ` Palmas regulator broken (was Re: [PATCH] ARM: tegra: TN7: relax some regulators) Nishanth Menon
2014-06-20 13:54 ` Nishanth Menon
2014-06-20 14:14 ` Alexandre Courbot
[not found] ` <CAAVeFuJ=JTNkwDKBvuoyL=ARQs_UJb_MHzL9S8gOc8EU98znPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-20 17:27 ` Nishanth Menon
2014-06-20 10:16 ` Mark Brown [this message]
[not found] ` <20140620101618.GU5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-20 10:33 ` [PATCH] ARM: tegra: TN7: relax some regulators Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620101618.GU5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=acourbot@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox