From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter De Schrijver Subject: Re: [PATCH] clk: define and export __clk_get_debug for providers Date: Thu, 26 Jun 2014 13:49:09 +0300 Message-ID: <20140626104909.GD3679@tbergstrom-lnx.Nvidia.com> References: <1403713591-17179-1-git-send-email-pdeschrijver@nvidia.com> <44039675.8s16pHQIVH@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <44039675.8s16pHQIVH@wuerfel> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mike Turquette , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Wed, Jun 25, 2014 at 08:07:37PM +0200, Arnd Bergmann wrote: > On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote: > > Define and export a new function __clk_get_debug which returns the debugfs > > directory entry pointer. This can be used by clock providers to add debugfs > > entries which are not related to a specific clock type. Examples include the > > ability to measure the rate of a clock. It can also be used by modules to > > create new debugfs entries. This is useful if you want to expose features > > for testing which can potentially cause system instability such as allowing > > to change a clock's rate from userspace. > > > > Signed-off-by: Peter De Schrijver > > > > Just an idea, but would it be better to add a pair of functions to add/remove > debugfs files rather than exposing the dentry itself? > Ok. Will do that. Cheers, Peter.