Re: [RFC 2/4] ARM: tegra: Add legacy interrupt controller nodes

Stephen Warren
2014-06-27T20:58:23Z

On 06/27/2014 10:58 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Add device tree nodes for the legacy interrupt controller so that the
> driver can get the register ranges from device tree rather than hard-
> coding them.

> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi

> + interrupt-controller@60004000 {
> + compatible = "nvidia,tegra20-ictlr";
> + reg = <0x60004000 0x40 /* primary controller */
> + 0x60004100 0x40 /* secondary controller */
> + 0x60004200 0x40 /* tertiary controller */
> + 0x60004300 0x40 /* quaternary controller */
> + 0x60004400 0x40>; /* quinary controller */
> + };

The quinary controller doesn't exist on Tegra20.

> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi

> + interrupt-controller@60004000 {
> + compatible = "nvidia,tegra20-ictlr";

At the least, each SoC should have an SoC-specific compatible value in
addition to the base Tegra20 value in case we need to differentiate them
in the future.

I'd be tempted to only include the SoC-specific value and omit the
Tegra20-specific value so we don't have to care whether they're really
100% backwards-compatible, but it's probably safe to say they're all
Tegra20 compatible (or all Tegra30 compatible given the 4-vs-5
controllers difference).