* [PATCH] staging: nvec: insert blank lines after declarations
@ 2014-07-03 19:15 Pawel Lebioda
2014-07-04 7:39 ` Marc Dietrich
0 siblings, 1 reply; 2+ messages in thread
From: Pawel Lebioda @ 2014-07-03 19:15 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Julian Andres Klode, linux-kernel, linux-tegra, ac100
Hi,
This patch fixes coding style warnings reported by checkpatch.pl:
"Missing a blank line after declarations".
Regards
Pawel Lebioda
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
drivers/staging/nvec/nvec_paz00.c | 1 +
drivers/staging/nvec/nvec_power.c | 1 +
drivers/staging/nvec/nvec_ps2.c | 2 ++
3 files changed, 4 insertions(+)
diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c
index 934b796..e2e675a 100644
--- a/drivers/staging/nvec/nvec_paz00.c
+++ b/drivers/staging/nvec/nvec_paz00.c
@@ -35,6 +35,7 @@ static void nvec_led_brightness_set(struct led_classdev *led_cdev,
{
struct nvec_led *led = to_nvec_led(led_cdev);
unsigned char buf[] = NVEC_LED_REQ;
+
buf[4] = value;
nvec_write_async(led->nvec, buf, sizeof(buf));
diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c
index aacfcd6..6446e15 100644
--- a/drivers/staging/nvec/nvec_power.c
+++ b/drivers/staging/nvec/nvec_power.c
@@ -226,6 +226,7 @@ static int nvec_power_get_property(struct power_supply *psy,
union power_supply_propval *val)
{
struct nvec_power *power = dev_get_drvdata(psy->dev->parent);
+
switch (psp) {
case POWER_SUPPLY_PROP_ONLINE:
val->intval = power->on;
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index 45b2f13..f56f1db 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -53,12 +53,14 @@ static struct nvec_ps2 ps2_dev;
static int ps2_startstreaming(struct serio *ser_dev)
{
unsigned char buf[] = { NVEC_PS2, AUTO_RECEIVE_N, PACKET_SIZE };
+
return nvec_write_async(ps2_dev.nvec, buf, sizeof(buf));
}
static void ps2_stopstreaming(struct serio *ser_dev)
{
unsigned char buf[] = { NVEC_PS2, CANCEL_AUTO_RECEIVE };
+
nvec_write_async(ps2_dev.nvec, buf, sizeof(buf));
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: nvec: insert blank lines after declarations
2014-07-03 19:15 [PATCH] staging: nvec: insert blank lines after declarations Pawel Lebioda
@ 2014-07-04 7:39 ` Marc Dietrich
0 siblings, 0 replies; 2+ messages in thread
From: Marc Dietrich @ 2014-07-04 7:39 UTC (permalink / raw)
To: Pawel Lebioda
Cc: Greg Kroah-Hartman, Julian Andres Klode,
ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
Am Donnerstag, 3. Juli 2014, 21:15:57 schrieb Pawel Lebioda:
> Hi,
>
> This patch fixes coding style warnings reported by checkpatch.pl:
> "Missing a blank line after declarations".
thanks. Looking at the checkpatch output, its requirement of at
least 4 lines of help text looks like a bit overkill though.
> Signed-off-by: Pawel Lebioda <pawel.lebioda89-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> drivers/staging/nvec/nvec_paz00.c | 1 +
> drivers/staging/nvec/nvec_power.c | 1 +
> drivers/staging/nvec/nvec_ps2.c | 2 ++
> 3 files changed, 4 insertions(+)
Acked-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-04 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-03 19:15 [PATCH] staging: nvec: insert blank lines after declarations Pawel Lebioda
2014-07-04 7:39 ` Marc Dietrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox