From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices() Date: Mon, 21 Jul 2014 14:20:13 -0700 Message-ID: <20140721212013.GA13866@kroah.com> References: <1405943561-2656-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1405943561-2656-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Thierry Reding Cc: linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, ac100@lists.launchpad.net List-Id: linux-tegra@vger.kernel.org On Mon, Jul 21, 2014 at 01:52:41PM +0200, Thierry Reding wrote: > From: Thierry Reding > > The mfd_add_devices() parameter takes a struct resource * as fifth > argument, but the nvec driver passes in a void __iomem *. The driver > gets away with it because none of the subdevices ever directly access > the registers. > > While at it, use platform_get_irq() instead of platform_get_resource() > to get the device's interrupt. This makes it easier to pass in the > register region since the variable is no longer reused. > > Signed-off-by: Thierry Reding > --- > Alternatively we could simply pass NULL into mfd_add_devices(), which > might be a slightly more accurate representation of what's going on. > > Marc, Greg, any preferences? None from me, Marc?