From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v2] platform: Make platform_bus device a platform device Date: Tue, 22 Jul 2014 10:10:13 -0700 Message-ID: <20140722171013.GA6605@kroah.com> References: <20140721184007.GB572@kroah.com> <1406023327-18525-1-git-send-email-pawel.moll@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1406023327-18525-1-git-send-email-pawel.moll-5wv7dgnIgG8@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pawel Moll Cc: Olof Johansson , Stephen Warren , Catalin Marinas , paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org, Arnd Bergmann , Peter De Schrijver , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Tue, Jul 22, 2014 at 11:02:07AM +0100, Pawel Moll wrote: > ... describing the root of the device tree, so one can write > a platform driver initializing the platform. > > All references to platform_bus device have been fixed up, > although in most cases they could be simply removed or > replaced by NULL (platform devices with no parent are adopted > by main platform_bus device automagically). In looking at this some more, I think all of these should be made NULL, why are we exporting this symbol at all? I think we should remove all of these references, and just make platform_bus static, like all other busses are, no reason platform should be "special" here. It's "special" enough as it is :( thanks, greg k-h