From: Tejun Heo <tj@kernel.org>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com,
linux-ide@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ata: ahci_tegra: Read calibration fuse
Date: Tue, 26 Aug 2014 10:50:59 -0400 [thread overview]
Message-ID: <20140826145059.GA29286@htj.dyndns.org> (raw)
In-Reply-To: <1409043630-9674-1-git-send-email-mperttunen@nvidia.com>
On Tue, Aug 26, 2014 at 12:00:30PM +0300, Mikko Perttunen wrote:
> The original version of the driver did not read the SATA calibration
> fuse to remove the dependency to the fuse driver. The fuse driver
> is now merged, so add this functionality.
>
> The calibration fuse contains a 2-bit value used to pick a set
> of calibration values for the SATA pad.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Applied to libata/for-3.17-fixes. One comment below.
> #include <linux/ahci_platform.h>
> -#include <linux/reset.h>
> #include <linux/errno.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regulator/consumer.h>
> +#include <linux/reset.h>
You moved the include of reset.h w/o any explanation in the patch
description. The description doesn't have to be super verbose on
trivial stuff but it at least has to cover all changes included in the
patch w/ their rationales, however trivial they may be.
Thanks.
--
tejun
prev parent reply other threads:[~2014-08-26 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 9:00 [PATCH v2] ata: ahci_tegra: Read calibration fuse Mikko Perttunen
2014-08-26 11:11 ` Thierry Reding
2014-08-26 14:50 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826145059.GA29286@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).