From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter De Schrijver Subject: Re: [PATCH v2 1/4] clk: tegra: Move mipi-cal initialization into clk-tegra1[12]4.c Date: Fri, 19 Sep 2014 14:28:02 +0300 Message-ID: <20140919112802.GO26779@tbergstrom-lnx.Nvidia.com> References: <1410360725-4286-1-git-send-email-seanpaul@chromium.org> <1410360725-4286-2-git-send-email-seanpaul@chromium.org> <541079A8.9080304@wwwdotorg.org> <20140918112621.GK26779@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sean Paul Cc: Stephen Warren , "thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Thu, Sep 18, 2014 at 08:59:53PM +0200, Sean Paul wrote: > On Thu, Sep 18, 2014 at 7:26 AM, Peter De Schrijver > wrote: > > On Wed, Sep 10, 2014 at 06:17:44PM +0200, Stephen Warren wrote: > >> On 09/10/2014 08:52 AM, Sean Paul wrote: > >> > This patch moves the mipi-cal gate registration down into the SoC > >> > specific files to reflect the different in parent between them. > >> > > >> > Without this change, MIPI calibration will fail on K1 devices if > >> > the 72MHz clock is off. > >> > >> This isn't a problem with this patch per se, but I notice that what's > >> removed from clk-tegra-periph.c is data in a table, whereas open-coded > >> calls are added to clk-tegra*.c. It'd be nice if the open-coded calls in > >> clk-tegra*.c could be converted to a table (simply with SoC-specific > >> data) and processed by the same function. Peter, would that make sense? > > > > Maybe yes. I will look into this. For this patch, it would make more sense > > to keep the entry in clk-tegra-periph.c as it can be used by both Tegra124 > > and Tegra132. > > > > How do you suggest we switch the parent based on 124 vs 132 if it > remains in clk-tegra-periph.c? > I would change the parent of mipi-cal in clk-tegra-periph.c to clk72mhz and use a different mechanism for Tegra114. Cheers, Peter.