From: Thierry Reding <thierry.reding@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com, Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 1/2] ARM: tegra: venice2: add GK20A GPU DT node
Date: Thu, 9 Oct 2014 10:00:18 +0200 [thread overview]
Message-ID: <20141009080016.GA1203@ulmo> (raw)
In-Reply-To: <54363DE8.9030102@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
On Thu, Oct 09, 2014 at 04:48:56PM +0900, Alexandre Courbot wrote:
> On 10/09/2014 04:43 PM, Thierry Reding wrote:
> >* PGP Signed by an unknown key
> >
> >On Thu, Oct 09, 2014 at 03:11:51PM +0900, Alexandre Courbot wrote:
> >>From: Thierry Reding <treding@nvidia.com>
> >>
> >>Add the device-tree node for the GK20A GPU and leave it disabled by
> >>default. It is the responsability of the bootloader to enable it if the
> >>VPR registers have been programmed such as the GPU can operate.
> >>
> >>Signed-off-by: Thierry Reding <treding@nvidia.com>
> >>Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> >>---
> >> arch/arm/boot/dts/tegra124-venice2.dts | 8 +++++++-
> >> 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> >Are you going to send the corresponding patches for U-Boot to update
> >the status property if it's initialized VPR?
>
> Yes. But maybe I should wait until upstream Nouveau actually works properly
> for that? Right now it will probe successfully, but will crash as soon as
> the GPU is used because there still are memory coherency problems.
I think the same really goes for these patches. Applying these will make
the node available to U-Boot, so technically some future U-Boot version
could modify a kernel DTB and boot a version where nouveau didn't yet
work out-of-the-box.
There's also still the issue about firmware loading and so on, so maybe
holding off on applying these patches until gk20a is fully enabled is a
good idea. Normally I guess this would be done by not adding the kernel
driver until it's expected to be at least usable to some degree, but I
guess it is a bit late for that now.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-09 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 6:11 [PATCH 1/2] ARM: tegra: venice2: add GK20A GPU DT node Alexandre Courbot
[not found] ` <1412835112-7209-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-09 6:11 ` [PATCH 2/2] ARM: tegra: jetson-tk1: " Alexandre Courbot
2014-10-09 7:43 ` [PATCH 1/2] ARM: tegra: venice2: " Thierry Reding
2014-10-09 7:48 ` Alexandre Courbot
2014-10-09 8:00 ` Thierry Reding [this message]
2014-10-09 8:05 ` Alexandre Courbot
2014-10-10 5:10 ` Stephen Warren
[not found] ` <54376A45.6070707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-10-10 7:01 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009080016.GA1203@ulmo \
--to=thierry.reding@gmail.com \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).