From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Alexandre Courbot
<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/2] ARM: tegra: venice2: add GK20A GPU DT node
Date: Fri, 10 Oct 2014 09:01:42 +0200 [thread overview]
Message-ID: <20141010070140.GA29675@ulmo.nvidia.com> (raw)
In-Reply-To: <54376A45.6070707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
On Thu, Oct 09, 2014 at 10:10:29PM -0700, Stephen Warren wrote:
> On 10/08/2014 11:11 PM, Alexandre Courbot wrote:
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > Add the device-tree node for the GK20A GPU and leave it disabled by
> > default. It is the responsability of the bootloader to enable it if the
> > VPR registers have been programmed such as the GPU can operate.
>
> > diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
>
> > + gpu@0,57000000 {
> > + status = "disabled";
>
> status="disabled" usually goes into tegra124.dtsi. A board would only
> override status to "okay" if necessary, and include any board specific
> properties ...
True. I guess this is somewhat redundant here since the .dtsi file
already sets it to "disabled". Given how it is rather unusual for a
board's DTS file to not enable a node I think there would be some
advantage in keeping this explicitly to avoid confusion. Alternatively
perhaps a comment in the DTS file about why this isn't enabled by
default would be a good replacement.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-10-10 7:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 6:11 [PATCH 1/2] ARM: tegra: venice2: add GK20A GPU DT node Alexandre Courbot
[not found] ` <1412835112-7209-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-09 6:11 ` [PATCH 2/2] ARM: tegra: jetson-tk1: " Alexandre Courbot
2014-10-09 7:43 ` [PATCH 1/2] ARM: tegra: venice2: " Thierry Reding
2014-10-09 7:48 ` Alexandre Courbot
2014-10-09 8:00 ` Thierry Reding
2014-10-09 8:05 ` Alexandre Courbot
2014-10-10 5:10 ` Stephen Warren
[not found] ` <54376A45.6070707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-10-10 7:01 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010070140.GA29675@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).