linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: drm/tegra: Add hardware cursor support
Date: Fri, 17 Oct 2014 14:31:23 +0300	[thread overview]
Message-ID: <20141017113123.GA24962@mwanda> (raw)

Hello Thierry Reding,

The patch e687651bc1ed: "drm/tegra: Add hardware cursor support" from
Dec 20, 2013, leads to the following static checker warning:

	drivers/gpu/drm/tegra/dc.c:597 tegra_dc_cursor_set2()
	warn: mask and shift to zero

drivers/gpu/drm/tegra/dc.c
   594          if (bo) {
   595                  unsigned long addr = (bo->paddr & 0xfffffc00) >> 10;
   596  #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
   597                  unsigned long high = (bo->paddr & 0xfffffffc) >> 32;
                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I'm not sure what the correct mask is.

   598  #endif
   599  

regards,
dan carpenter

             reply	other threads:[~2014-10-17 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17 11:31 Dan Carpenter [this message]
2014-10-17 13:15 ` drm/tegra: Add hardware cursor support Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141017113123.GA24962@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).