* Re: [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree
[not found] ` <CAOMFOmXDqhwCk1pRf_9yGycboMqt-ZE33y=kZrhbqXOjVcrxYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-11-07 4:16 ` Stephen Warren
[not found] ` <545C4783.8070506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2014-11-07 4:16 UTC (permalink / raw)
To: Anatol Pomozov
Cc: Marc Zyngier, mark.rutland-5wv7dgnIgG8, Lorenzo Pieralisi, LKML,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On 11/06/2014 05:25 PM, Anatol Pomozov wrote:
> +Stephen
>
> This patch is for tegra20_timer that uses register_persistent_clock().
> I did not find any way to share the same arch code for arm/arm64.
>
> Actually this register_persistent_clock() does not look arm specific
> at all. Would it be better to move it somewhere outside of arch/?
No CC to linux-tegra@ or the other Tegra maintainers?
Yes, I think it'd be best not to have arch-specific APIs, or cut/paste
the same code into multiple places.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree
[not found] ` <545C4783.8070506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2014-11-07 10:40 ` Mark Rutland
2014-11-07 16:24 ` Anatol Pomozov
0 siblings, 1 reply; 4+ messages in thread
From: Mark Rutland @ 2014-11-07 10:40 UTC (permalink / raw)
To: Stephen Warren
Cc: Anatol Pomozov, Marc Zyngier, Lorenzo Pieralisi, LKML,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Fri, Nov 07, 2014 at 04:16:03AM +0000, Stephen Warren wrote:
> On 11/06/2014 05:25 PM, Anatol Pomozov wrote:
> > +Stephen
> >
> > This patch is for tegra20_timer that uses register_persistent_clock().
> > I did not find any way to share the same arch code for arm/arm64.
> >
> > Actually this register_persistent_clock() does not look arm specific
> > at all. Would it be better to move it somewhere outside of arch/?
>
> No CC to linux-tegra@ or the other Tegra maintainers?
>
> Yes, I think it'd be best not to have arch-specific APIs, or cut/paste
> the same code into multiple places.
Agreed. This looks in no way architecture specific, and having this in
common code would be preferable to copying.
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree
2014-11-07 10:40 ` Mark Rutland
@ 2014-11-07 16:24 ` Anatol Pomozov
[not found] ` <CAOMFOmWfgtN+Q-sbQUS8-90pTrtk5Du8xkDVXaed=teVPb8sbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Anatol Pomozov @ 2014-11-07 16:24 UTC (permalink / raw)
To: Mark Rutland
Cc: Stephen Warren, Marc Zyngier, Lorenzo Pieralisi, LKML,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Hi
On Fri, Nov 7, 2014 at 2:40 AM, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> On Fri, Nov 07, 2014 at 04:16:03AM +0000, Stephen Warren wrote:
>> On 11/06/2014 05:25 PM, Anatol Pomozov wrote:
>> > +Stephen
>> >
>> > This patch is for tegra20_timer that uses register_persistent_clock().
>> > I did not find any way to share the same arch code for arm/arm64.
>> >
>> > Actually this register_persistent_clock() does not look arm specific
>> > at all. Would it be better to move it somewhere outside of arch/?
>>
>> No CC to linux-tegra@ or the other Tegra maintainers?
>>
>> Yes, I think it'd be best not to have arch-specific APIs, or cut/paste
>> the same code into multiple places.
>
> Agreed. This looks in no way architecture specific, and having this in
> common code would be preferable to copying.
Where the code common for arm and arm64 should go?
drivers/???/arm_timekeeping.c ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree
[not found] ` <CAOMFOmWfgtN+Q-sbQUS8-90pTrtk5Du8xkDVXaed=teVPb8sbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-11-07 16:38 ` Mark Rutland
0 siblings, 0 replies; 4+ messages in thread
From: Mark Rutland @ 2014-11-07 16:38 UTC (permalink / raw)
To: Anatol Pomozov
Cc: Stephen Warren, Marc Zyngier, Lorenzo Pieralisi, LKML,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Fri, Nov 07, 2014 at 04:24:19PM +0000, Anatol Pomozov wrote:
> Hi
>
> On Fri, Nov 7, 2014 at 2:40 AM, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> > On Fri, Nov 07, 2014 at 04:16:03AM +0000, Stephen Warren wrote:
> >> On 11/06/2014 05:25 PM, Anatol Pomozov wrote:
> >> > +Stephen
> >> >
> >> > This patch is for tegra20_timer that uses register_persistent_clock().
> >> > I did not find any way to share the same arch code for arm/arm64.
> >> >
> >> > Actually this register_persistent_clock() does not look arm specific
> >> > at all. Would it be better to move it somewhere outside of arch/?
> >>
> >> No CC to linux-tegra@ or the other Tegra maintainers?
> >>
> >> Yes, I think it'd be best not to have arch-specific APIs, or cut/paste
> >> the same code into multiple places.
> >
> > Agreed. This looks in no way architecture specific, and having this in
> > common code would be preferable to copying.
>
> Where the code common for arm and arm64 should go?
> drivers/???/arm_timekeeping.c ?
I'd argue that this is in no way specific to ARM, and the current weak
functions live in kernel/time/timekeeping.c, so this should too.
Thanks,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-07 16:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1415319665-21701-1-git-send-email-anatol.pomozov@gmail.com>
[not found] ` <CAOMFOmXDqhwCk1pRf_9yGycboMqt-ZE33y=kZrhbqXOjVcrxYQ@mail.gmail.com>
[not found] ` <CAOMFOmXDqhwCk1pRf_9yGycboMqt-ZE33y=kZrhbqXOjVcrxYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07 4:16 ` [PATCH] arm64: kernel: Copy register_persistent_clock() to arm64 source subtree Stephen Warren
[not found] ` <545C4783.8070506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-11-07 10:40 ` Mark Rutland
2014-11-07 16:24 ` Anatol Pomozov
[not found] ` <CAOMFOmWfgtN+Q-sbQUS8-90pTrtk5Du8xkDVXaed=teVPb8sbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-07 16:38 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).