Re: [PATCH v2 3/3] soc/tegra: fuse: Add Tegra132 support

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]

On Fri, Jan 09, 2015 at 12:49:25PM +0900, Alexandre Courbot wrote:
> On Thu, Jan 8, 2015 at 5:55 PM, Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
> > Tegra132 is very similar to Tegra124 from a peripheral point of view and
> > uses the same fuse controller.
> >
> > Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > ---
> > Changes in v2:
> > - add missing break in Tegra132 case for legacy fuse init (Vince Hsu)
> >
> >  drivers/soc/tegra/fuse/fuse-tegra.c   | 1 +
> >  drivers/soc/tegra/fuse/fuse-tegra30.c | 3 +++
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
> > index 011a3363c265..c0d660f1aaac 100644
> > --- a/drivers/soc/tegra/fuse/fuse-tegra.c
> > +++ b/drivers/soc/tegra/fuse/fuse-tegra.c
> > @@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = {
> >         { .compatible = "nvidia,tegra30-car", },
> >         { .compatible = "nvidia,tegra114-car", },
> >         { .compatible = "nvidia,tegra124-car", },
> > +       { .compatible = "nvidia,tegra132-car", },
> >         {},
> >  };
> >
> > diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
> > index d1a4290cda5c..9e3679594259 100644
> > --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> > +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> > @@ -184,6 +184,9 @@ static void __init legacy_fuse_init(void)
> >         case TEGRA124:
> >                 fuse_info = &tegra124_info;
> >                 break;
> > +       case TEGRA132:
> > +               fuse_info = &tegra124_info;
> > +               break;
> 
> Nit, but why not
> 
>         case TEGRA124:
> +       case TEGRA132:
>                 fuse_info = &tegra124_info;
>                 break;

Yes, that's even better.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]