* [PATCH] drm/tegra: Fix copypasta in host1x_reloc_copy_from_user
@ 2015-01-21 2:37 David Ung
[not found] ` <1421807855-27853-1-git-send-email-davidu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: David Ung @ 2015-01-21 2:37 UTC (permalink / raw)
To: airlied-cv59FeDIM0c
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
swarren-3lzwWm7+Weoh9ZMKESR00Q,
amerilainen-DDmLM1+adcrQT0dZR+AlfA, David Ung
Fix copypasta bug for function host1x_reloc_copy_from_user.
Signed-off-by: David Ung <davidu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
drivers/gpu/drm/tegra/drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index d4f8275..d8c9fb7 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -190,7 +190,7 @@ static int host1x_reloc_copy_from_user(struct host1x_reloc *dest,
if (err < 0)
return err;
- err = get_user(dest->target.offset, &src->cmdbuf.offset);
+ err = get_user(dest->target.offset, &src->target.offset);
if (err < 0)
return err;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tegra: Fix copypasta in host1x_reloc_copy_from_user
[not found] ` <1421807855-27853-1-git-send-email-davidu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2015-01-23 11:24 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2015-01-23 11:24 UTC (permalink / raw)
To: David Ung
Cc: airlied-cv59FeDIM0c, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
swarren-3lzwWm7+Weoh9ZMKESR00Q,
amerilainen-DDmLM1+adcrQT0dZR+AlfA
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
On Tue, Jan 20, 2015 at 06:37:35PM -0800, David Ung wrote:
> Fix copypasta bug for function host1x_reloc_copy_from_user.
>
> Signed-off-by: David Ung <davidu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/gpu/drm/tegra/drm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've applied this with a reworded commit message and added a proper
Fixes: tag. It should also go to stable because the offending commit was
merged in v3.17. Yay for not having automated test procedures that could
have easily caught this...
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-23 11:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-21 2:37 [PATCH] drm/tegra: Fix copypasta in host1x_reloc_copy_from_user David Ung
[not found] ` <1421807855-27853-1-git-send-email-davidu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-01-23 11:24 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).