Re: [tegrarcm PATCH v1 3/8] tegrarcm: Get platform info

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On Tue, Mar 17, 2015 at 05:38:56PM -0700, Jimmy Zhang wrote:
> From: Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Add two newly added platform info fields for t132.
> 
> 	uint32_t warranty_fuse;
> 	uint8_t skip_auto_detect;
> 
> Signed-off-by: Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Jimmy Zhang <jimmzhang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  src/main.c | 30 +++++++++++++++++++++++-------
>  src/nv3p.c |  6 +++++-
>  src/nv3p.h |  9 +++++++++
>  src/rcm.h  |  1 +
>  4 files changed, 38 insertions(+), 8 deletions(-)

I'd prefer if we didn't apply this. As far as I can tell this was an
incompatible change introduced in some version of the miniloader and was
subsequently reverted because Allen complained about it. So if we merge
this change we're going to be in a bad place where we potentially need
to support two different versions of this command on Tegra132.

Rather than go that route I think we should stop supporting the blob
miniloaders post Tegra124 and rather switch to a different model for
newer chips. The miniloader for Tegra210 doesn't support nv3p v1, so
we'll need to come up with a different plan anyway.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]