Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2102 bytes --]

On Thu, Apr 02, 2015 at 11:13:38PM +0000, David Ung wrote:
> > -----Original Message-----
> > From: Alexandre Courbot [mailto:gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> > Sent: Monday, March 30, 2015 11:30 PM
> > To: David Ung; thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
> > Cc: airlied-cv59FeDIM0c@public.gmane.org; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org; Arto Merilainen; Terje Bergstrom
> > Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size
> > 
> > On Tue, Mar 24, 2015 at 4:39 AM, David Ung <davidu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> > >
> > >> -----Original Message-----
> > >> From: Alexandre Courbot [mailto:gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> > >> Sent: Monday, March 23, 2015 12:09 AM
> > >> To: David Ung
> > >> Cc: airlied-cv59FeDIM0c@public.gmane.org; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > >> thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org; Arto Merilainen;
> > >> Terje Bergstrom
> > >> Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation
> > >> size
> > >>
> > >> The series looks ok to me, the only problem I see is that we are
> > >> lacking means to thoroughly test host1x patches across all the
> > >> supported Tegra chips.
> > >>
> > >> Could you detail what kind of testing this patch series has
> > >> undergone, and which chips/boards have been tested?
> > >
> > > Tested the host1x channel tests for T132 on A44.
> > > Also ran Paul's EIMT set up which only tests booting kernel to console
> > > for T20/T30/T114/T124 and QEMU
> > 
> > Thierry, what do you think?
> > 
> > I know we are lacking proper testing infrastructure for host1x, but these
> > patches really looks harmless to me.
> 
> 
> Thank you Alex for the review.
> It would be good to have closure to this patchset. 

We'll get closure on this once the testing infrastructure appears. I
won't apply these patches before then.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]