From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH 10/15] PCI: kill off set_irq_flags usage Date: Thu, 18 Jun 2015 11:59:54 -0500 Message-ID: <20150618165954.GE7710@google.com> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-11-git-send-email-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1433874401-27161-11-git-send-email-robh@kernel.org> Sender: linux-pci-owner@vger.kernel.org To: Rob Herring Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, Kishon Vijay Abraham I , Murali Karicheri , Thierry Reding , Stephen Warren , Alexandre Courbot , Jingoo Han , Pratyush Anand , Simon Horman , Michal Simek , =?iso-8859-1?Q?S=F6ren?= Brinkmann , linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-sh@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On Tue, Jun 09, 2015 at 01:26:36PM -0500, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, s= o we > can kill off set_irq_flags. The translation of flags is as follows: >=20 > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN >=20 > For IRQs managed by an irqdomain, the irqdomain core code handles cle= aring > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. So= me > users also set IRQ_NOPROBE and this has been maintained although it i= s not > clear that is really needed. There appears to be a great deal of blin= d > copy and paste of this code. >=20 > Signed-off-by: Rob Herring > Cc: Kishon Vijay Abraham I > Cc: Bjorn Helgaas > Cc: Murali Karicheri > Cc: Thierry Reding > Cc: Stephen Warren > Cc: Alexandre Courbot > Cc: Jingoo Han > Cc: Pratyush Anand > Cc: Simon Horman > Cc: Michal Simek > Cc: "S=F6ren Brinkmann" > Cc: linux-omap@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > Cc: linux-sh@vger.kernel.org This is the only part of the series on linux-pci, so I assume this will= be merged by somebody else along with the rest. Acked-by: Bjorn Helgaas > --- > drivers/pci/host/pci-dra7xx.c | 1 - > drivers/pci/host/pci-keystone-dw.c | 2 -- > drivers/pci/host/pci-tegra.c | 1 - > drivers/pci/host/pcie-designware.c | 1 - > drivers/pci/host/pcie-rcar.c | 1 - > drivers/pci/host/pcie-xilinx.c | 2 -- > 6 files changed, 8 deletions(-) >=20 > diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra= 7xx.c > index 2d57e19..94cbc4d 100644 > --- a/drivers/pci/host/pci-dra7xx.c > +++ b/drivers/pci/host/pci-dra7xx.c > @@ -160,7 +160,6 @@ static int dra7xx_pcie_intx_map(struct irq_domain= *domain, unsigned int irq, > { > irq_set_chip_and_handler(irq, &dummy_irq_chip, handle_simple_irq); > irq_set_chip_data(irq, domain->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > return 0; > } > diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pc= i-keystone-dw.c > index f34892e..f1d0749 100644 > --- a/drivers/pci/host/pci-keystone-dw.c > +++ b/drivers/pci/host/pci-keystone-dw.c > @@ -196,7 +196,6 @@ static int ks_dw_pcie_msi_map(struct irq_domain *= domain, unsigned int irq, > irq_set_chip_and_handler(irq, &ks_dw_pcie_msi_irq_chip, > handle_level_irq); > irq_set_chip_data(irq, domain->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > return 0; > } > @@ -277,7 +276,6 @@ static int ks_dw_pcie_init_legacy_irq_map(struct = irq_domain *d, > irq_set_chip_and_handler(irq, &ks_dw_pcie_legacy_irq_chip, > handle_level_irq); > irq_set_chip_data(irq, d->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > return 0; > } > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegr= a.c > index 00e9272..36bd700 100644 > --- a/drivers/pci/host/pci-tegra.c > +++ b/drivers/pci/host/pci-tegra.c > @@ -1263,7 +1263,6 @@ static int tegra_msi_map(struct irq_domain *dom= ain, unsigned int irq, > { > irq_set_chip_and_handler(irq, &tegra_msi_irq_chip, handle_simple_ir= q); > irq_set_chip_data(irq, domain->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > tegra_cpuidle_pcie_irqs_in_use(); > =20 > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pc= ie-designware.c > index 2e9f84f..5caa94d 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -333,7 +333,6 @@ static int dw_pcie_msi_map(struct irq_domain *dom= ain, unsigned int irq, > { > irq_set_chip_and_handler(irq, &dw_msi_irq_chip, handle_simple_irq); > irq_set_chip_data(irq, domain->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > return 0; > } > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rca= r.c > index c086210..7678fe0 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -664,7 +664,6 @@ static int rcar_msi_map(struct irq_domain *domain= , unsigned int irq, > { > irq_set_chip_and_handler(irq, &rcar_msi_irq_chip, handle_simple_irq= ); > irq_set_chip_data(irq, domain->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > return 0; > } > diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-x= ilinx.c > index f1a06a0..72015119 100644 > --- a/drivers/pci/host/pcie-xilinx.c > +++ b/drivers/pci/host/pcie-xilinx.c > @@ -338,7 +338,6 @@ static int xilinx_pcie_msi_map(struct irq_domain = *domain, unsigned int irq, > { > irq_set_chip_and_handler(irq, &xilinx_msi_irq_chip, handle_simple_i= rq); > irq_set_chip_data(irq, domain->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > return 0; > } > @@ -377,7 +376,6 @@ static int xilinx_pcie_intx_map(struct irq_domain= *domain, unsigned int irq, > { > irq_set_chip_and_handler(irq, &dummy_irq_chip, handle_simple_irq); > irq_set_chip_data(irq, domain->host_data); > - set_irq_flags(irq, IRQF_VALID); > =20 > return 0; > } > --=20 > 2.1.0 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kerne= l" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/