From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 10/12] drm/tegra: Suspend dc/dsi/panel in one-shot mode Date: Wed, 1 Jul 2015 11:00:05 +0200 Message-ID: <20150701090005.GC24055@phenom.ffwll.local> References: <1435738915-31973-1-git-send-email-markz@nvidia.com> <1435738915-31973-11-git-send-email-markz@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1435738915-31973-11-git-send-email-markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Zhang Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, daniel-/w4YWyX8dFk@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Wed, Jul 01, 2015 at 04:21:53PM +0800, Mark Zhang wrote: > @@ -756,7 +752,11 @@ tegra_dsi_connector_duplicate_state(struct drm_connector *connector) > } > > static const struct drm_connector_funcs tegra_dsi_connector_funcs = { > - .dpms = tegra_dsi_connector_dpms, > + /* > + * drm_atomic_helper_connector_dpms only handles DPMS ON/OFF, > + * so use drm_helper_connector_dpms instead. > + */ > + .dpms = drm_helper_connector_dpms, Nope, mixing legacy dpms handling into an atomic driver is a no-go. You need to use drm_atomic_helper_connector_dpms here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch