Re: [RFC PATCH 06/15] pwm: define a new pwm_state struct

Boris Brezillon
2015-07-20T10:01:16Z

On Mon, 20 Jul 2015 10:04:59 +0200
Thierry Reding <thierry.reding@gmail.com> wrote:

> On Wed, Jul 01, 2015 at 10:21:52AM +0200, Boris Brezillon wrote:
> [...]
> > diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> [...]
> > +struct pwm_state {
> > + unsigned int period; /* in nanoseconds */
> > + unsigned int duty_cycle; /* in nanoseconds */
> > + enum pwm_polarity polarity;
> > +};
>
> No need for the extra padding here.

What do you mean by "extra padding" ?
I just reused the indentation used in the pwm_device struct.

Would you prefer something like that ?

struct pwm_state {
unsigned int period; /* in nanoseconds */
unsigned int duty_cycle; /* in nanoseconds */
enum pwm_polarity polarity;
};

--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering