linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 5/5] drm/tegra: Fix module autoload for OF platform driver
@ 2015-09-17 14:22 Luis de Bethencourt
  2015-09-18 15:36 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-09-17 14:22 UTC (permalink / raw)
  To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Thierry Reding, Terje =?unknown-8bit?Q?Bergstr=C3=B6m?=,
	David Airlie, Stephen Warren, Alexandre Courbot,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
---
 drivers/gpu/drm/tegra/drm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 2486bc2..62d724d 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -1064,6 +1064,7 @@ static const struct of_device_id host1x_drm_subdevs[] = {
 	{ .compatible = "nvidia,tegra210-sor1", },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, host1x_drm_subdevs);
 
 static struct host1x_driver host1x_drm_driver = {
 	.driver = {
-- 
2.4.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 5/5] drm/tegra: Fix module autoload for OF platform driver
  2015-09-17 14:22 [PATCH 5/5] drm/tegra: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-18 15:36 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2015-09-18 15:36 UTC (permalink / raw)
  To: Luis de Bethencourt
  Cc: Alexandre Courbot, Terje Bergström, Stephen Warren,
	linux-kernel, dri-devel, linux-tegra


[-- Attachment #1.1: Type: text/plain, Size: 864 bytes --]

On Thu, Sep 17, 2015 at 04:22:32PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/gpu/drm/tegra/drm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
> index 2486bc2..62d724d 100644
> --- a/drivers/gpu/drm/tegra/drm.c
> +++ b/drivers/gpu/drm/tegra/drm.c
> @@ -1064,6 +1064,7 @@ static const struct of_device_id host1x_drm_subdevs[] = {
>  	{ .compatible = "nvidia,tegra210-sor1", },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, host1x_drm_subdevs);

This shouldn't be necessary because the MODULE_DEVICE_TABLE entries are
already in the subdrivers.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-18 15:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-17 14:22 [PATCH 5/5] drm/tegra: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-18 15:36 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).