Re: [cbootimage PATCH 3/3] Add support to read and write rsa related fields on t124

[Alban Bedel <alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

On Wed, 11 Nov 2015 09:41:08 -0700
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:

> On 11/05/2015 09:03 AM, Alban Bedel wrote:
> > This allow creating and reading signed images for secure boot on t124.
> 
> This patch looks like it's identical to the equivalent code for T210. 
> Does it depend on your other two patches, or is it independent, such 
> that I can apply it now?

Yes, this can be applied without the rest.

> It'd be nice if we could share code between src/tNNN/nvbctlib_tNNN.c 
> somehow rather than duplicating it all, but that's not a problem this 
> patch introduces, so no need to attempt that now.

That would be quiet nice, but that would probably require quiet a large
rework of the current abstraction. I suspect it would need to move to
some description of the BCT that include the offset of each field. That
way the parsers/set/get functions wouldn't need to be reimplemented for
each BCT version.

Alban

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]