Re: [PATCH V4 11/16] Documentation: DT: bindings: Update NVIDIA PMC for Tegra210

Rob Herring
2015-12-06T00:31:07Z

On Fri, Dec 04, 2015 at 02:57:12PM +0000, Jon Hunter wrote:
> ---
> Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt
> index 02c27004d4a8..838e1a69ec0a 100644
> --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt
> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt
> @@ -9,8 +9,9 @@ Required properties:
> - compatible : For Tegra20, must contain "nvidia,tegra20-pmc". For Tegra30,
> must contain "nvidia,tegra30-pmc". For Tegra114, must contain
> "nvidia,tegra114-pmc". For Tegra124, must contain "nvidia,tegra124-pmc".
> - Otherwise, must contain "nvidia,<chip>-pmc", plus at least one of the
> - above, where <chip> is tegra132.
> + For Tegra210, must contain "nvidia,tegra210-pmc". Otherwise, must contain
> + "nvidia,<chip>-pmc", plus at least one of the above, where <chip> is
> + tegra132.

Can you reorg this some so the compatible strings are a list rather than
a paragraph of text. I find the last sentence a bit confusing as well.
Seems like <chip> should be a list rather than just tegra132.

> - reg : Offset and length of the register set for the device
> - clocks : Must contain an entry for each entry in clock-names.
> See ../clocks/clock-bindings.txt for details.
> --
> 2.1.4
>