Re: [PATCH V6 06/10] soc: tegra: pmc: Wait for powergate state to change

Jon Hunter
2016-02-29T10:38:29Z

On 29/02/16 07:24, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Fri, Feb 26, 2016 at 03:48:40PM +0000, Jon Hunter wrote:
>> Currently, the function tegra_powergate_set() simply sets the desired
>> powergate state but does not wait for the state to change. In most cases
>> we should wait for the state to change before proceeding. Currently, there
>> is a case for tegra114 and tegra124 devices where we do not wait when
>> starting the secondary CPU as this is not necessary. However, this is only
>> done at boot time and so waiting here will only have a small impact on
>> boot time. Therefore, update tegra_powergate_set() to wait when setting
>> the powergate.
>>
>> By adding this feature, we can also eliminate the polling loop from
>> tegra30_boot_secondary().
>>
>> A function has been added for checking the status of the powergate and
>> so update the tegra_powergate_is_powered() to use this macro as well.
>>
>> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> arch/arm/mach-tegra/platsmp.c | 16 +++-------------
>> drivers/soc/tegra/pmc.c | 9 ++++++++-
>> 2 files changed, 11 insertions(+), 14 deletions(-)
>
> This looks to be independent from the generic power domain support. Can
> I apply this separately (for 4.6, without waiting for the power domain
> series' dependencies to go in)?

Yes this could be applied independently of this series for v4.6. I just
wanted to make sure that this change is added before the genpd changes
are applied.

Cheers
Jon