Re: [PATCH V6 10/10] ARM64: tegra: Add audio PM domain device node for Tegra210

Thierry Reding
2016-02-29T10:54:47Z

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

On Mon, Feb 29, 2016 at 10:41:50AM +0000, Jon Hunter wrote:
>
>
> On 29/02/16 07:30, Thierry Reding wrote:
> > * PGP Signed by an unknown key
> >
> > On Fri, Feb 26, 2016 at 03:48:44PM +0000, Jon Hunter wrote:
> >> Add the audio power-domain for tegra210. Note that this also removes the
> >> existing "#power-domain-cells" which was incorrectly included by
> >> commit e53095857166 ("arm64: tegra: Add Tegra210 support").
> >>
> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> >>
> >> ---
> >>
> >> So far I have only added the audio power-domain for tegra210 as this is
> >> what I have been testing with to date. However, once this series is
> >> accepted then we can begin to add more.
> >>
> >> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 14 +++++++++++++-
> >> 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > I'm slightly reluctant to apply this, since the domain isn't used
> > anywhere. I'm assuming it will be used by the audio driver that you've
> > been working on, but if that's not going to be merged this cycle, we'd
> > end up with an unused label. Not that that's invalid in any way, but my
> > rule of thumb has been not to introduce labels until they are used.
> >
> > Therefore I suggest we postpone this to the series that adds audio
> > support.
>
> That's fine with me or I can drop the label, until it is used by a device?

I'd prefer the former, no use in having anything in device tree that
we're not using anyway. Unless we need this somehow to automatically
turn off the domain at boot, in which case it might make more sense
to add all others as well.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]