public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] regulator: Fix deadlock during regulator registration
Date: Wed, 30 Mar 2016 10:00:53 -0700	[thread overview]
Message-ID: <20160330170053.GK2350@sirena.org.uk> (raw)
In-Reply-To: <56FC02CD.60107@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

On Wed, Mar 30, 2016 at 05:46:05PM +0100, Jon Hunter wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> > Please don't paste entire backlogs into changelogs, they're *enormous*,
> > mostly noise and obscure any actual content that's in there through
> > denial of service.  If they're useful then include edited subsets that
> > highlight the relevant sections of the backtrace so your changelog is
> > more legible.

> Ok, no problem. Are you happy with the patch otherwise? If so, do you
> want me to resend or do you wish to trim the backlog? I think that

I haven't reviwed it yet.

> this part is interesting ...

I'm really getting nothing at all from this, all it really does is point
to the call site but that's already much more clearly identified in the
changelog.  We certainly don't need to know which driver called this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-03-30 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 16:09 [PATCH] regulator: Fix deadlock during regulator registration Jon Hunter
2016-03-30 16:18 ` Mark Brown
     [not found]   ` <20160330161831.GE2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-30 16:46     ` Jon Hunter
2016-03-30 17:00       ` Mark Brown [this message]
     [not found]         ` <20160330170053.GK2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-30 17:41           ` Jon Hunter
     [not found] ` <1459354153-6352-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-30 23:25   ` Javier Martinez Canillas
     [not found]     ` <56FC607D.3020108-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-03-30 23:34       ` Mark Brown
     [not found]         ` <20160330233427.GZ2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-30 23:38           ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330170053.GK2350@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=javier@osg.samsung.com \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox