On Fri, Jun 10, 2016 at 03:33:25PM +0100, Jon Hunter wrote: > > On 10/06/16 15:22, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote: > >> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing > >> from the cpuidle.c file, it is defined in > >> so add that include to avoid the following warning: > >> > >> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? > >> > >> Signed-off-by: Ben Dooks > >> --- > >> Cc: Stephen Warren > >> Cc: Alexandre Courbot > >> Cc: Thierry Reding > >> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > >> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> --- > >> arch/arm/mach-tegra/cpuidle.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > I've been carrying a set of patches to fix these, and a couple of other > > sparse warnings, in my tree locally, but never sent them out because > > they were so trivial. I probably should've to avoid the duplication of > > effort. Sorry about that. > > I think you did send them out ;-) > > http://patchwork.ozlabs.org/patch/616249/ > http://patchwork.ozlabs.org/patch/616250/ > http://patchwork.ozlabs.org/patch/616251/ > http://patchwork.ozlabs.org/patch/616252/ Hah! Excellent. No more guilty conscience for me. =) I've pulled those patches into the Tegra tree now. Thanks, Thierry