Re: [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2

Rhyland Klein
2016-06-14T15:35:56Z

On 6/14/2016 8:00 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Enabling spread spectrum on pll_d2 can lead to issues with display
> modes. HDMI monitors, for example, would report "Signal Error" and
> some modes driven over DisplayPort would generate fuzzy horizontal
> bands.
>
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/clk/tegra/clk-tegra210.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c
> index 6bd1235d09b1..cd141a364c9d 100644
> --- a/drivers/clk/tegra/clk-tegra210.c
> +++ b/drivers/clk/tegra/clk-tegra210.c
> @@ -1914,8 +1914,9 @@ static struct tegra_clk_pll_params pll_d2_params = {
> .sdm_din_mask = PLLA_SDM_DIN_MASK,
> .sdm_ctrl_reg = PLLD2_MISC1,
> .sdm_ctrl_en_mask = PLLD2_SDM_EN_MASK,
> - .ssc_ctrl_reg = PLLD2_MISC1,
> - .ssc_ctrl_en_mask = PLLD2_SSC_EN_MASK,
> + /* disable spread-spectrum for pll_d2 */
> + .ssc_ctrl_reg = 0,
> + .ssc_ctrl_en_mask = 0,
> .round_p_to_pdiv = pll_qlin_p_to_pdiv,
> .pdiv_tohw = pll_qlin_pdiv_to_hw,
> .div_nmp = &pllss_nmp,
>

Acked-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

--
nvpublic