From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 8/8] dmaengine: Remove site specific OOM error messages on kzalloc Date: Wed, 15 Jun 2016 22:38:28 +0530 Message-ID: <20160615170828.GD16910@localhost> References: <1465321121-22238-1-git-send-email-peter.griffin@linaro.org> <1465321121-22238-9-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "open list:ARM/STI ARCHITECTURE" , Dan Williams , Leo Li , Zhang Wei , Barry Song , Maxime Ripard , Chen-Yu Tsai , Laxman Dewangan , Jon Hunter , Stephen Warren , Thierry Reding , Alexandre Courbot , Lee Jones , dmaengine@vger.kernel.org, "linux-tegra@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org list" List-Id: linux-tegra@vger.kernel.org On Wed, Jun 08, 2016 at 02:12:27PM +0200, Linus Walleij wrote: > On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin wrote: > > > If kzalloc() fails it will issue it's own error message including > > a dump_stack(). So remove the site specific error messages. > > > > Signed-off-by: Peter Griffin > > Acked-by: Linus Walleij > > A few subsystems may use a cleanup like this... > I wonder how many unnecessary prints I've introduced > myself :P Yes that should be case with mine too :) I think adding a coccinelle script and doing this treewise might be great Thanks -- ~Vinod