From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] gpu: host1x: hw: intr_hw: Remove create_workqueue
Date: Mon, 20 Jun 2016 11:11:23 -0400 [thread overview]
Message-ID: <20160620151123.GY3262@mtj.duckdns.org> (raw)
In-Reply-To: <20160618090632.GA11246@Karyakshetra>
On Sat, Jun 18, 2016 at 02:36:32PM +0530, Bhaktipriya Shridhar wrote:
> System workqueues have been able to handle high level of concurrency
> for a long time now and there's no reason to use dedicated workqueues
> just to gain concurrency. Since the workqueue host->intr_wq is involved
> in sync point interrupts, and sync point wait and is not being used on
> a memory reclaim path, dedicated host->intr_wq has been replaced with the
> use of system_wq.
>
> Unlike a dedicated per-cpu workqueue created with create_workqueue(),
> system_wq allows multiple work items to overlap executions even on
> the same CPU; however, a per-cpu workqueue doesn't have any CPU
> locality or global ordering guarantees unless the target CPU is
> explicitly specified and thus the increase of local concurrency
> shouldn't make any difference.
>
> cancel_work_sync() has been used in _host1x_free_syncpt_irq() to ensure
> that no work is pending by the time exit path runs.
Alternatively, this could have used alloc_workqueue() w/o
WQ_MEM_RECLAIM and used it just as a flush domain. Either way is
fine.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-20 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 9:06 [PATCH v2] gpu: host1x: hw: intr_hw: Remove create_workqueue Bhaktipriya Shridhar
2016-06-20 15:11 ` Tejun Heo [this message]
[not found] ` <20160620151123.GY3262-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-06-28 16:44 ` Bhaktipriya Shridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620151123.GY3262@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=bhaktipriya96@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox