public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] soc/tegra: pmc: Use consistent naming for PM domains
@ 2016-11-08 10:08 Thierry Reding
       [not found] ` <20161108100807.5114-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2016-11-08 10:08 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Jon Hunter, Laxman Dewangan, linux-tegra-u79uwXL29TY76Z2rM5mHXA

From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

The various error messages refer to the PM domains as "power domain",
"genpd" and "PM domain". That's confusing, so convert all error messages
to use the most prominent: "PM domain".

Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/soc/tegra/pmc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 84d1623d8d79..933b06abe8a2 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -867,19 +867,19 @@ static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np)
 
 	err = pm_genpd_init(&pg->genpd, NULL, off);
 	if (err < 0) {
-		pr_err("failed to initialise power domain %s: %d\n", np->name,
+		pr_err("failed to initialise PM domain %s: %d\n", np->name,
 		       err);
 		goto remove_resets;
 	}
 
 	err = of_genpd_add_provider_simple(np, &pg->genpd);
 	if (err < 0) {
-		pr_err("failed to add genpd provider for %s: %d\n", np->name,
-		       err);
+		pr_err("failed to add PM domain provider for %s: %d\n",
+		       np->name, err);
 		goto remove_genpd;
 	}
 
-	pr_debug("added power domain %s\n", pg->genpd.name);
+	pr_debug("added PM domain %s\n", pg->genpd.name);
 
 	return;
 
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc/tegra: pmc: Use consistent naming for PM domains
       [not found] ` <20161108100807.5114-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-11-08 10:15   ` Jon Hunter
  2016-11-08 11:11   ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2016-11-08 10:15 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Laxman Dewangan, linux-tegra-u79uwXL29TY76Z2rM5mHXA


On 08/11/16 10:08, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> The various error messages refer to the PM domains as "power domain",
> "genpd" and "PM domain". That's confusing, so convert all error messages
> to use the most prominent: "PM domain".
> 
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/soc/tegra/pmc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 84d1623d8d79..933b06abe8a2 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -867,19 +867,19 @@ static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np)
>  
>  	err = pm_genpd_init(&pg->genpd, NULL, off);
>  	if (err < 0) {
> -		pr_err("failed to initialise power domain %s: %d\n", np->name,
> +		pr_err("failed to initialise PM domain %s: %d\n", np->name,
>  		       err);
>  		goto remove_resets;
>  	}
>  
>  	err = of_genpd_add_provider_simple(np, &pg->genpd);
>  	if (err < 0) {
> -		pr_err("failed to add genpd provider for %s: %d\n", np->name,
> -		       err);
> +		pr_err("failed to add PM domain provider for %s: %d\n",
> +		       np->name, err);
>  		goto remove_genpd;
>  	}
>  
> -	pr_debug("added power domain %s\n", pg->genpd.name);
> +	pr_debug("added PM domain %s\n", pg->genpd.name);
>  
>  	return;

Acked-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Cheers
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] soc/tegra: pmc: Use consistent naming for PM domains
       [not found] ` <20161108100807.5114-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2016-11-08 10:15   ` Jon Hunter
@ 2016-11-08 11:11   ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2016-11-08 11:11 UTC (permalink / raw)
  To: Jon Hunter, Laxman Dewangan, linux-tegra-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

On Tue, Nov 08, 2016 at 11:08:07AM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> The various error messages refer to the PM domains as "power domain",
> "genpd" and "PM domain". That's confusing, so convert all error messages
> to use the most prominent: "PM domain".
> 
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/soc/tegra/pmc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-08 11:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-08 10:08 [PATCH] soc/tegra: pmc: Use consistent naming for PM domains Thierry Reding
     [not found] ` <20161108100807.5114-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-08 10:15   ` Jon Hunter
2016-11-08 11:11   ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox