public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bus: tegra-gmi: fix build error
@ 2016-11-08 13:50 Arnd Bergmann
       [not found] ` <20161108135058.1991567-1-arnd-r2nGTMty4D4@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-11-08 13:50 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Arnd Bergmann, Stephen Warren, Alexandre Courbot, Jon Hunter,
	Mirza Krak, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

The newly added driver fails to build right away:

drivers/bus/tegra-gmi.c: In function 'tegra_gmi_parse_dt':
drivers/bus/tegra-gmi.c:97:11: error: 'dev' undeclared (first use in this function)

I guess a last-minute change removed a local variable, this
adds the obvious definiton.

Fixes: 4f95e6a5c9e4 ("bus: Add support for Tegra Generic Memory Interface")
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
---
 drivers/bus/tegra-gmi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/tegra-gmi.c b/drivers/bus/tegra-gmi.c
index 44ee73186c5e..8b6ab0dd2f4c 100644
--- a/drivers/bus/tegra-gmi.c
+++ b/drivers/bus/tegra-gmi.c
@@ -90,9 +90,10 @@ static int tegra_gmi_parse_dt(struct tegra_gmi *gmi)
 {
 	struct device_node *child;
 	u32 property, ranges[4];
+	struct device *dev = gmi->dev;
 	int err;
 
-	child = of_get_next_available_child(gmi->dev->of_node, NULL);
+	child = of_get_next_available_child(dev->of_node, NULL);
 	if (!child) {
 		dev_err(dev, "no child nodes found\n");
 		return -ENODEV;
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bus: tegra-gmi: fix build error
       [not found] ` <20161108135058.1991567-1-arnd-r2nGTMty4D4@public.gmane.org>
@ 2016-11-08 15:45   ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2016-11-08 15:45 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Stephen Warren, Alexandre Courbot, Jon Hunter, Mirza Krak,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

On Tue, Nov 08, 2016 at 02:50:29PM +0100, Arnd Bergmann wrote:
> The newly added driver fails to build right away:
> 
> drivers/bus/tegra-gmi.c: In function 'tegra_gmi_parse_dt':
> drivers/bus/tegra-gmi.c:97:11: error: 'dev' undeclared (first use in this function)
> 
> I guess a last-minute change removed a local variable, this
> adds the obvious definiton.
> 
> Fixes: 4f95e6a5c9e4 ("bus: Add support for Tegra Generic Memory Interface")
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> ---
>  drivers/bus/tegra-gmi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

This got reported by the 0-day builder earlier. Turns out this slipped
through because my build setup failed to pick up the new configuration
option. I pushed a fix for this to the Tegra tree, so it should all be
good by tomorrow.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-08 15:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-08 13:50 [PATCH] bus: tegra-gmi: fix build error Arnd Bergmann
     [not found] ` <20161108135058.1991567-1-arnd-r2nGTMty4D4@public.gmane.org>
2016-11-08 15:45   ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox