Re: [PATCH] ARM: tegra: paz00: fix __initdata placement

Marc Dietrich
2017-01-23T10:04:22Z

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]

Hello Dmitry,

Am Sonntag, 22. Januar 2017, 23:43:47 CET schrieb Dmitry Torokhov:
> To have expected effect the __initdata attribute should go after variable
> name and before initializer.`
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/mach-tegra/board-paz00.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c
> b/arch/arm/mach-tegra/board-paz00.c index 7478f6fb3664..ea6bff404161 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -23,7 +23,7 @@
>
> #include "board.h"
>
> -static struct property_entry __initdata wifi_rfkill_prop[] = {
> +static struct property_entry wifi_rfkill_prop[] __initdata = {
> PROPERTY_ENTRY_STRING("name", "wifi_rfkill"),
> PROPERTY_ENTRY_STRING("type", "wlan"),
> { },

you are right according to the documentation, but objdump -s always shows that
it gets put into the .rodata section. So this patch has no effect, because
result is always same (and wrong). It's also possible that I'm doing something
wrong :-) Btw, there are hundreds of such __initdata misplacement in the
kernel.

Marc

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]