From: simran singhal <singhalsimran0@gmail.com>
To: marvin24@gmx.de
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
linux-tegra@vger.kernel.org, ac100@lists.launchpad.net
Subject: [PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks
Date: Thu, 2 Mar 2017 19:54:19 +0530 [thread overview]
Message-ID: <20170302142418.GA16773@singhal-Inspiron-5558> (raw)
Resolve strict checkpatch USLEEP_RANGE checks by converting delays and
sleeps as described in ./Documentation/timers/timers-howto.txt.
CHECK: usleep_range is preferred over udelay; see Documentation/
timers/timers-howto.txt
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index c1feccf..cd35e64 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
break;
case 2: /* first byte after command */
if (status == (I2C_SL_IRQ | RNW | RCVD)) {
- udelay(33);
+ usleep_range(33, 100);
if (nvec->rx->data[0] != 0x01) {
dev_err(nvec->dev,
"Read without prior read command\n");
@@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
* We experience less incomplete messages with this delay than without
* it, but we don't know why. Help is appreciated.
*/
- udelay(100);
+ usleep_range(100, 200);
return IRQ_HANDLED;
}
--
2.7.4
next reply other threads:[~2017-03-02 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 14:24 simran singhal [this message]
2017-03-02 14:36 ` [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks Julia Lawall
[not found] ` <b90bc602-cf06-4abb-bea2-6386d4976864@googlegroups.com>
2017-03-02 14:57 ` [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGEcheckpatch checks Marc Dietrich
2017-03-08 12:46 ` Thierry Reding
2017-03-02 15:01 ` [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks Julia Lawall
[not found] ` <4958c8a8-4b50-4567-91d8-9554e9bdf7f6@googlegroups.com>
2017-03-02 15:18 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302142418.GA16773@singhal-Inspiron-5558 \
--to=singhalsimran0@gmail.com \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox