From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Laxman Dewangan <ldewangan@nvidia.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: fix link errors with PMC disabled
Date: Mon, 20 Mar 2017 12:10:46 +0100 [thread overview]
Message-ID: <20170320111046.GA20431@ulmo.ba.sec> (raw)
In-Reply-To: <e17797ae-35db-8254-ed38-c90b9d29ff0d@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
On Mon, Mar 20, 2017 at 09:47:39AM +0000, Jon Hunter wrote:
> Hi Arnd,
>
> On 20/03/17 09:13, Arnd Bergmann wrote:
> > With the new Tegra186 PMC driver merged, anything that relies on the previous
> > PMC driver fails to link when that is disabled:
> >
> > arch/arm/mach-tegra/pm.o: In function `tegra_pm_set':
> > pm.c:(.text.tegra_pm_set+0x3c): undefined reference to `tegra_pmc_enter_suspend_mode'
> > arch/arm/mach-tegra/pm.o: In function `tegra_suspend_enter':
> > pm.c:(.text.tegra_suspend_enter+0x4): undefined reference to `tegra_pmc_get_suspend_mode'
> > arch/arm/mach-tegra/pm.o: In function `tegra_init_suspend':
> > pm.c:(.init.text+0x1c): undefined reference to `tegra_pmc_get_suspend_mode'
> > pm.c:(.init.text+0x74): undefined reference to `tegra_pmc_set_suspend_mode'
> >
> > ERROR: tegra_powergate_sequence_power_up [drivers/ata/ahci_tegra.ko] undefined!
> > ERROR: tegra_powergate_power_off [drivers/ata/ahci_tegra.ko] undefined!
> >
> > Making the definition depend on the presence of the driver makes it build
> > again, though that might not be the correct fix.
> >
> > Fixes: 854014236290 ("soc/tegra: Implement Tegra186 PMC support")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> A fix was also submitted by Krzysztof [0].
>
> Thierry, what's your preference? Maybe Arnd's approach is better.
Yes, I prefer Arnd's patch because it is more consistent with how we
deal with this kind of dependency elsewhere.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-20 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:13 [PATCH] soc/tegra: fix link errors with PMC disabled Arnd Bergmann
2017-03-20 9:47 ` Jon Hunter
2017-03-20 11:10 ` Thierry Reding [this message]
2017-03-20 12:40 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320111046.GA20431@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).