From: Thierry Reding <thierry.reding@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Stefan Kristiansson <stefank@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH v2 1/3] PM / Domains: Allow overriding the ->xlate() callback
Date: Wed, 29 Mar 2017 18:34:50 +0200 [thread overview]
Message-ID: <20170329163452.10761-2-thierry.reding@gmail.com> (raw)
In-Reply-To: <20170329163452.10761-1-thierry.reding@gmail.com>
From: Thierry Reding <treding@nvidia.com>
Allow generic power domain providers to override the ->xlate() callback
in case the default genpd_xlate_onecell() translation callback is not
good enough.
One potential use-case for this is to allow generic power domains to be
specified by an ID rather than an index.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/base/power/domain.c | 8 ++++----
include/linux/pm_domain.h | 4 ++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index e697dec9d25b..c102557f6c7e 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1570,9 +1570,6 @@ EXPORT_SYMBOL_GPL(pm_genpd_remove);
#ifdef CONFIG_PM_GENERIC_DOMAINS_OF
-typedef struct generic_pm_domain *(*genpd_xlate_t)(struct of_phandle_args *args,
- void *data);
-
/*
* Device Tree based PM domain providers.
*
@@ -1730,6 +1727,9 @@ int of_genpd_add_provider_onecell(struct device_node *np,
mutex_lock(&gpd_list_lock);
+ if (!data->xlate)
+ data->xlate = genpd_xlate_onecell;
+
for (i = 0; i < data->num_domains; i++) {
if (!data->domains[i])
continue;
@@ -1740,7 +1740,7 @@ int of_genpd_add_provider_onecell(struct device_node *np,
data->domains[i]->has_provider = true;
}
- ret = genpd_add_provider(np, genpd_xlate_onecell, data);
+ ret = genpd_add_provider(np, data->xlate, data);
if (ret < 0)
goto error;
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index 5339ed5bd6f9..5163f371a308 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -204,9 +204,13 @@ static inline void pm_genpd_syscore_poweron(struct device *dev) {}
/* OF PM domain providers */
struct of_device_id;
+typedef struct generic_pm_domain *(*genpd_xlate_t)(struct of_phandle_args *args,
+ void *data);
+
struct genpd_onecell_data {
struct generic_pm_domain **domains;
unsigned int num_domains;
+ genpd_xlate_t xlate;
};
#ifdef CONFIG_PM_GENERIC_DOMAINS_OF
--
2.12.0
next prev parent reply other threads:[~2017-03-29 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 16:34 [PATCH v2 0/3] soc/tegra: bpmp: Generic PM domains for Tegra186 Thierry Reding
2017-03-29 16:34 ` Thierry Reding [this message]
2017-04-19 14:32 ` [PATCH v2 1/3] PM / Domains: Allow overriding the ->xlate() callback Ulf Hansson
[not found] ` <20170329163452.10761-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-29 16:34 ` [PATCH v2 2/3] soc/tegra: bpmp: Update ABI header Thierry Reding
2017-04-20 0:44 ` Rafael J. Wysocki
[not found] ` <10169152.Khpl4fl1AK-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2017-04-27 14:19 ` Thierry Reding
2017-03-29 16:34 ` [PATCH v2 3/3] soc/tegra: bpmp: Implement generic PM domains Thierry Reding
[not found] ` <20170329163452.10761-4-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-19 14:32 ` Ulf Hansson
2017-04-11 15:28 ` [PATCH v2 0/3] soc/tegra: bpmp: Generic PM domains for Tegra186 Thierry Reding
[not found] ` <20170411152838.GA13819-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2017-04-11 19:37 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329163452.10761-2-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=khilman@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=stefank@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox