From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2] dmaengine: tegra-apb: Really fix runtime-pm usage
Date: Fri, 30 Jun 2017 11:12:49 +0530 [thread overview]
Message-ID: <20170630054249.GO19154@localhost> (raw)
In-Reply-To: <f336e72a-d966-11e4-0885-e324843d5c00-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Tue, Jun 27, 2017 at 12:44:58PM +0100, Jon Hunter wrote:
> >> static const struct dev_pm_ops tegra_dma_dev_pm_ops = {
> >> SET_RUNTIME_PM_OPS(tegra_dma_runtime_suspend, tegra_dma_runtime_resume,
> >> NULL)
> >> - SET_SYSTEM_SLEEP_PM_OPS(tegra_dma_pm_suspend, tegra_dma_pm_resume)
> >> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> >> + pm_runtime_force_resume)
> >
> > Is that even necessary? I thought runtime PM was going to be triggered
> > for system sleep anyway, but it looks like there are other examples of
> > this usage, so maybe I'm mistaken.
>
> Yes this is necessary. No RPM is not automatically trigger by system
> suspend AFAICT.
Yes I was earlier under the same impression but later did realize that the
behaviour seems to be arch specific and we don't have guarantee on this
--
~Vinod
next prev parent reply other threads:[~2017-06-30 5:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 12:49 [PATCH V2] dmaengine: tegra-apb: Really fix runtime-pm usage Jon Hunter
[not found] ` <1496753369-5356-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-06-06 14:48 ` Thierry Reding
2017-06-27 11:44 ` Jon Hunter
[not found] ` <f336e72a-d966-11e4-0885-e324843d5c00-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-06-30 5:42 ` Vinod Koul [this message]
2017-06-30 5:44 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630054249.GO19154@localhost \
--to=vinod.koul-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox