From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: [PATCH] drm/tegra: vic: add NULL check on of_match_device() return value Date: Fri, 7 Jul 2017 01:16:26 -0500 Message-ID: <20170707061626.GA14016@embeddedgus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding , David Airlie , Jonathan Hunter Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-Id: linux-tegra@vger.kernel.org Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/tegra/vic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c index 47cb1aa..7e11825 100644 --- a/drivers/gpu/drm/tegra/vic.c +++ b/drivers/gpu/drm/tegra/vic.c @@ -283,6 +283,11 @@ static int vic_probe(struct platform_device *pdev) int err; match = of_match_device(vic_match, dev); + if (!match) { + dev_err(&pdev->dev, "failed to match device\n"); + return -ENODEV; + } + vic_config = (struct vic_config *)match->data; vic = devm_kzalloc(dev, sizeof(*vic), GFP_KERNEL); -- 2.5.0