linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Timo Alho <talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] firmware: tegra: propagate error code to caller
Date: Tue, 17 Oct 2017 12:41:24 +0200	[thread overview]
Message-ID: <20171017104124.GD30589@ulmo> (raw)
In-Reply-To: <c349d38a8cb1d00a4dc11d6aa286fb392017bc8c.1504776489.git.talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Thu, Sep 07, 2017 at 12:31:01PM +0300, Timo Alho wrote:
> Response messages from Tegra BPMP firmware contain an error return
> code as the first word of payload. The error code is used to indicate
> incorrectly formatted request message or use of non-existing resource
> (clk, reset, powergate) identifier. Current implementation of
> tegra_bpmp_transfer() ignores this code and does not pass it to
> caller. Fix this by adding an extra struct member to
> tegra_bpmp_message and populate that with return code.
> 
> Signed-off-by: Timo Alho <talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/firmware/tegra/bpmp.c | 22 ++++++++++++++++------
>  include/soc/tegra/bpmp.h      |  1 +
>  2 files changed, 17 insertions(+), 6 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-10-17 10:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07  9:31 [PATCH 0/4] firmware: tegra: add checks for BPMP error return code Timo Alho
     [not found] ` <cover.1504776489.git.talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-09-07  9:31   ` [PATCH 1/4] firmware: tegra: propagate error code to caller Timo Alho
     [not found]     ` <c349d38a8cb1d00a4dc11d6aa286fb392017bc8c.1504776489.git.talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-09-21 11:19       ` Jon Hunter
2017-10-17 10:41       ` Thierry Reding [this message]
2017-09-07  9:31   ` [PATCH 2/4] clk: tegra: check BPMP response return code Timo Alho
2017-09-21 11:21     ` Jon Hunter
     [not found]       ` <388e07bc-b7b4-cc17-026a-bd08d77942ca-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-09-29 13:46         ` Timo Alho
2017-09-29 14:53           ` Jon Hunter
     [not found]             ` <5dfbbc6d-0dc0-7d92-0bff-8b05ddd272b3-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-10-02  8:43               ` Timo Alho
2017-10-02 20:23                 ` Jon Hunter
2017-10-17 10:37     ` Thierry Reding
2017-10-21 14:10       ` Stephen Boyd
2017-09-07  9:31   ` [PATCH 3/4] reset: " Timo Alho
     [not found]     ` <00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-10-02 20:24       ` Jon Hunter
2017-10-17 10:40     ` Thierry Reding
2017-10-17 10:52       ` Philipp Zabel
     [not found]         ` <1508237537.6854.8.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-17 11:49           ` Thierry Reding
2017-09-07  9:31 ` [PATCH 4/4] soc/tegra: bpmp: " Timo Alho
     [not found]   ` <8be4357544ffb9a60e116bc0a666189b93951c91.1504776489.git.talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-10-02 20:26     ` Jon Hunter
2017-10-17 10:41   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017104124.GD30589@ulmo \
    --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).