From: Thierry Reding <thierry.reding@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v7 14/15] gpio: Introduce struct gpio_irq_chip.first
Date: Tue, 7 Nov 2017 19:15:58 +0100 [thread overview]
Message-ID: <20171107181559.6318-15-thierry.reding@gmail.com> (raw)
In-Reply-To: <20171107181559.6318-1-thierry.reding@gmail.com>
From: Thierry Reding <treding@nvidia.com>
Some GPIO chips cannot support sparse IRQ numbering and therefore need
to manually allocate their interrupt descriptors statically. For these
cases, a driver can pass the first allocated IRQ via the struct
gpio_irq_chip's "first" field and thereby cause the IRQ domain to map
all IRQs during initialization.
Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpio/gpiolib.c | 3 ++-
include/linux/gpio/driver.h | 8 ++++++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 17f4b843f058..35fb13e98d84 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1778,7 +1778,8 @@ static int gpiochip_add_irqchip(struct gpio_chip *gpiochip)
ops = &gpiochip_domain_ops;
gpiochip->irq.domain = irq_domain_add_simple(np, gpiochip->ngpio,
- 0, ops, gpiochip);
+ gpiochip->irq.first,
+ ops, gpiochip);
if (!gpiochip->irq.domain)
return -EINVAL;
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 3fd7438f3596..241af05498f9 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -129,6 +129,14 @@ struct gpio_irq_chip {
* in IRQ domain of the chip.
*/
unsigned long *valid_mask;
+
+ /**
+ * @first:
+ *
+ * Required for static IRQ allocation. If set, irq_domain_add_simple()
+ * will allocate and map all IRQs during initialization.
+ */
+ unsigned int first;
};
static inline struct gpio_irq_chip *to_gpio_irq_chip(struct irq_chip *chip)
--
2.14.1
next prev parent reply other threads:[~2017-11-07 18:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 18:15 [PATCH v7 00/15] gpio: Tight IRQ chip integration Thierry Reding
2017-11-07 18:15 ` [PATCH v7 01/15] gpio: Introduce struct gpio_irq_chip Thierry Reding
2017-11-07 18:15 ` [PATCH v7 02/15] gpio: Move irqchip into " Thierry Reding
2017-11-07 18:15 ` [PATCH v7 03/15] gpio: Move irqdomain " Thierry Reding
2017-11-07 18:15 ` [PATCH v7 04/15] gpio: Move irq_handler to " Thierry Reding
2017-11-07 18:15 ` [PATCH v7 05/15] gpio: Move irq_default_type " Thierry Reding
2017-11-07 18:15 ` [PATCH v7 06/15] gpio: Move irq_chained_parent " Thierry Reding
2017-11-07 18:15 ` [PATCH v7 07/15] gpio: Move irq_nested into " Thierry Reding
2017-11-07 18:15 ` [PATCH v7 08/15] gpio: Move irq_valid_mask " Thierry Reding
[not found] ` <20171107181559.6318-9-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-15 15:57 ` Grygorii Strashko
[not found] ` <20171107181559.6318-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-07 18:15 ` [PATCH v7 09/15] gpio: Move lock_key " Thierry Reding
2017-11-08 13:30 ` [PATCH v7 00/15] gpio: Tight IRQ chip integration Linus Walleij
2017-11-07 18:15 ` [PATCH v7 10/15] gpio: Implement tighter " Thierry Reding
2017-11-07 18:15 ` [PATCH v7 11/15] gpio: Export gpiochip_irq_{map,unmap}() Thierry Reding
2017-11-07 18:15 ` [PATCH v7 12/15] gpio: Add Tegra186 support Thierry Reding
2017-11-07 18:15 ` [PATCH v7 13/15] gpio: Disambiguate struct gpio_irq_chip.nested Thierry Reding
2017-11-07 18:15 ` Thierry Reding [this message]
2017-11-07 18:15 ` [PATCH v7 15/15] gpio: Automatically add lockdep keys Thierry Reding
[not found] ` <20171107181559.6318-16-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-08 13:21 ` Linus Walleij
2017-11-07 20:02 ` [PATCH v7 00/15] gpio: Tight IRQ chip integration Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107181559.6318-15-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).