Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [bug report] clk: tegra: dfll: Properly clean up on failure and removal
Date: Mon, 13 Nov 2017 14:00:49 +0300	[thread overview]
Message-ID: <20171113110049.fkjrxptvxfef3cg4@mwanda> (raw)

Hello Thierry Reding,

The patch f7c42d986217: "clk: tegra: dfll: Properly clean up on
failure and removal" from Apr 8, 2016, leads to the following static
checker warning:

	drivers/clk/tegra/clk-tegra124-dfll-fcpu.c:140 tegra124_dfll_fcpu_remove()
	error: 'soc' dereferencing possible ERR_PTR()

drivers/clk/tegra/clk-tegra124-dfll-fcpu.c
   131  static int tegra124_dfll_fcpu_remove(struct platform_device *pdev)
   132  {
   133          struct tegra_dfll_soc_data *soc;
   134  
   135          soc = tegra_dfll_unregister(pdev);
   136          if (IS_ERR(soc))
                           ^^^
   137                  dev_err(&pdev->dev, "failed to unregister DFLL: %ld\n",
   138                          PTR_ERR(soc));
   139  
   140          tegra_cvb_remove_opp_table(soc->dev, soc->cvb, soc->max_freq);
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

   141  
   142          return 0;
   143  }


regards,
dan carpenter

                 reply	other threads:[~2017-11-13 11:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171113110049.fkjrxptvxfef3cg4@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox