From: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] clk: tegra20: Add 216 MHz entry for PLL_X
Date: Tue, 12 Dec 2017 12:02:00 +0200 [thread overview]
Message-ID: <20171212100200.GW32106@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <adc15215591018b4a35a7d64e065f81bb09e214e.1513018125.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, Dec 11, 2017 at 09:50:09PM +0300, Dmitry Osipenko wrote:
> The cpufreq driver uses 216 MHz as the lowest CPU clock frequency, but
> clock driver doesn't provide that rate, so the requested clock is rounded
> up to 312 MHz. Let's add entry for 216 MHz to match with cpufreq.
>
This seems odd. If there's no table entry, _calc_rate should kick in and
calculate the parameters for 216MHz. Any idea why this is not happening?
Peter.
> Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/clk/tegra/clk-tegra20.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c
> index cbd5a2e5c569..e33d7548a4e9 100644
> --- a/drivers/clk/tegra/clk-tegra20.c
> +++ b/drivers/clk/tegra/clk-tegra20.c
> @@ -269,6 +269,11 @@ static struct tegra_clk_pll_freq_table pll_x_freq_table[] = {
> { 13000000, 312000000, 312, 13, 1, 12 },
> { 19200000, 312000000, 260, 16, 1, 8 },
> { 26000000, 312000000, 312, 26, 1, 12 },
> + /* 216 MHz */
> + { 12000000, 216000000, 216, 12, 1, 12 },
> + { 13000000, 216000000, 216, 13, 1, 12 },
> + { 19200000, 216000000, 180, 16, 1, 8 },
> + { 26000000, 216000000, 216, 26, 1, 12 },
> { 0, 0, 0, 0, 0, 0 },
> };
>
> --
> 2.15.1
>
next prev parent reply other threads:[~2017-12-12 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 18:50 [PATCH v1] clk: tegra20: Add 216 MHz entry for PLL_X Dmitry Osipenko
[not found] ` <adc15215591018b4a35a7d64e065f81bb09e214e.1513018125.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-11 18:50 ` [PATCH v1 1/2] clk: tegra: Mark HCLK, SCLK, EMC, MC and PLL_P outputs as critical Dmitry Osipenko
2017-12-11 18:50 ` [PATCH v1 2/2] clk: tegra20: Correct PLL_C_OUT1 setup Dmitry Osipenko
[not found] ` <4c15ac578fd847bc4047384ae2f8cadd6b9e9fe4.1513018140.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 10:15 ` Peter De Schrijver
[not found] ` <09480d74d240d8e77b3989cfe85e6e624eaee866.1513018140.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 10:06 ` [PATCH v1 1/2] clk: tegra: Mark HCLK, SCLK, EMC, MC and PLL_P outputs as critical Peter De Schrijver
2017-12-11 18:50 ` [PATCH v1] clk: tegra: Specify VDE clock rate Dmitry Osipenko
[not found] ` <41813e7cda9ade75637d6c25b0a1b004462058f4.1513018131.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 10:18 ` Peter De Schrijver
2017-12-12 10:02 ` Peter De Schrijver [this message]
2017-12-12 12:08 ` [PATCH v1] clk: tegra20: Add 216 MHz entry for PLL_X Dmitry Osipenko
[not found] ` <508cb22d-42cb-d169-dbea-0073d7a4e034-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 15:17 ` Peter De Schrijver
[not found] ` <20171212151749.GA29158-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2017-12-12 21:37 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212100200.GW32106@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox