Re: [PATCH v3 07/11] dt-bindings: tegra: Update DFLL binding for PWM regulator

Peter De Schrijver
2018-03-12T09:10:36Z

On Thu, Mar 08, 2018 at 11:21:40PM +0000, Jon Hunter wrote:
>
> On 06/02/18 16:34, Peter De Schrijver wrote:
> > Add new properties to configure the DFLL PWM regulator support. Also
> > add an example and make the I2C clock only required when I2C support is
> > used.
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > ---
> > .../bindings/clock/nvidia,tegra124-dfll.txt | 76 +++++++++++++++++++++-
> > 1 file changed, 74 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt b/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> > index dff236f..a4903f7 100644
> > --- a/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> > +++ b/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> > @@ -23,7 +23,8 @@ Required properties:
> > - clock-names: Must include the following entries:
> > - soc: Clock source for the DFLL control logic.
> > - ref: The closed loop reference clock
> > - - i2c: Clock source for the integrated I2C master.
> > + - i2c: Clock source for the integrated I2C master (only required when
> > + using I2C mode).
> > - resets: Must contain an entry for each entry in reset-names.
> > See ../reset/reset.txt for details.
> > - reset-names: Must include the following entries:
> > @@ -45,10 +46,28 @@ Required properties for the control loop parameters:
> > Optional properties for the control loop parameters:
> > - nvidia,cg-scale: Boolean value, see the field DFLL_PARAMS_CG_SCALE in the TRM.
> >
> > +Optional properties for mode selection:
> > +- nvidia,pwm-to-pmic: Use PWM to control regulator rather then I2C.
> > +
>
> Do we need this property? Seems that we should be able to detect if it
> is I2C or PWM based upon the other properties.
>

I guess we could look for nvidia,pwm-period and switch to PWM mode if this is
found, but I think it's more clear to have explicit property.

Peter.