From: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Mikko Perttunen <cyndis-/1wQRMveznE@public.gmane.org>
Cc: jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 0/4] MBIST work around (WAR) for Tegra210
Date: Mon, 12 Feb 2018 14:34:11 +0200 [thread overview]
Message-ID: <20180212123411.GJ5850@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <a40f0593-24d8-a91e-9f8c-f7eafc379591-/1wQRMveznE@public.gmane.org>
On Mon, Feb 12, 2018 at 02:05:36PM +0200, Mikko Perttunen wrote:
> This seems to cause a system hang with an HDMI monitor attached -
> likely in unpowergate as if I disable powergating the hang doesn't
> happen.
>
> Have you tested with a display attached?
>
Yes. A DSI display at least seems to work.
Peter.
> Mikko
>
> On 01/25/2018 04:00 PM, Peter De Schrijver wrote:
> >This patch series introduces the Memory Built-In Self Test (MBIST)
> >work around (WAR) needed when power ungating certain domains. More
> >details can be found in 'clk: tegra: MBIST WAR for Tegra210'. I choose to
> >implement the WAR in the Tegra210 clock driver, because most accesses are
> >to CAR registers and for the VENC domain, we need to make sure the CSI
> >clock source is not changed during the WAR execution.
> >
> >Changes in v4:
> >* moved locking and clock control to tegra210_clk_handle_mbist_war()
> >* propagate errors during WAR execution to user
> >* rework error handling tegra210_mbist_clk_init() slightly
> >
> >Changes in v3:
> >* fix compile problem on non-Tegra210 platforms
> >* fix clock handling bug in tegra210_generic_mbist_war()
> >* addressed minor comments
> >
> >Changes in v2:
> >* Use readl for fence_delay() rather than readl_relaxed
> >* clarify MBIST and WAR acronyms
> >
> >Peter De Schrijver (4):
> > clk: tegra: Add la clock for Tegra210
> > clk: tegra: add fence_delay for clock registers
> > clk: tegra: MBIST work around for Tegra210
> > soc/tegra: pmc: MBIST work around for Tegra210
> >
> > drivers/clk/tegra/clk-tegra210.c | 357 ++++++++++++++++++++++++++++++-
> > drivers/clk/tegra/clk.h | 7 +
> > drivers/soc/tegra/pmc.c | 7 +
> > include/dt-bindings/clock/tegra210-car.h | 2 +-
> > include/linux/clk/tegra.h | 6 +
> > 5 files changed, 376 insertions(+), 3 deletions(-)
> >
next prev parent reply other threads:[~2018-02-12 12:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 14:00 [PATCH v4 0/4] MBIST work around (WAR) for Tegra210 Peter De Schrijver
[not found] ` <1516888813-32180-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2018-01-25 14:00 ` [PATCH v4 1/4] clk: tegra: Add la clock " Peter De Schrijver
2018-01-25 14:00 ` [PATCH v4 3/4] clk: tegra: MBIST work around " Peter De Schrijver
2018-01-26 9:37 ` [PATCH v4 0/4] MBIST work around (WAR) " Jon Hunter
2018-02-12 16:17 ` Hector Martin 'marcan'
2018-01-25 14:00 ` [PATCH v4 2/4] clk: tegra: add fence_delay for clock registers Peter De Schrijver
2018-01-25 14:00 ` [PATCH v4 4/4] soc/tegra: pmc: MBIST work around for Tegra210 Peter De Schrijver
2018-02-12 12:05 ` [PATCH v4 0/4] MBIST work around (WAR) " Mikko Perttunen
[not found] ` <a40f0593-24d8-a91e-9f8c-f7eafc379591-/1wQRMveznE@public.gmane.org>
2018-02-12 12:34 ` Peter De Schrijver [this message]
2018-02-13 9:32 ` Mikko Perttunen
2018-02-12 16:09 ` Thierry Reding
2018-02-13 5:54 ` Andre Heider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212123411.GJ5850@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=cyndis-/1wQRMveznE@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox