From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcus Folkesson Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Date: Tue, 20 Feb 2018 14:21:03 +0100 Message-ID: <20180220132103.GD24311@gmail.com> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3831320097026872127==" Return-path: In-Reply-To: <20180220124955.GA17814@sophia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: William Breathitt Gray Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Baruch Siach , Mans Rullgard , Maxime Ripard , Benjamin Herrenschmidt , Linus Walleij , Patrice Chotard , Eric Anholt , Thierry Reding , Alexandre Belloni , Michael Ellerman , Baoyou Xie , Stefan Wahren , Florian Fainelli , Kevin Hilman , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Joel Stanley , Sylvain Lemieux List-Id: linux-tegra@vger.kernel.org --===============3831320097026872127== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MZf7D3rAEoQgPanC" Content-Disposition: inline --MZf7D3rAEoQgPanC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello William, On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >- Add SPDX identifier > >- Remove boiler plate license text > >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > > license > > > >Signed-off-by: Marcus Folkesson > >Acked-by: Adam Thomson > >Acked-by: Charles Keepax > >Acked-by: Nicolas Ferre > >Acked-by: Michal Simek > >--- > > > >Notes: > > v2: > > - Put back removed copyright texts for meson_gxbb_wdt and coh901327= _wdt > > - Change to BSD-3-Clause for meson_gxbb_wdt > > v1: Please have an extra look at meson_gxbb_wdt.c >=20 > [...] >=20 > >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384= _wdt.c > >index 2170b275ea01..c173b6f5c866 100644 > >--- a/drivers/watchdog/ebc-c384_wdt.c > >+++ b/drivers/watchdog/ebc-c384_wdt.c > >@@ -1,15 +1,8 @@ > >+// SPDX-License-Identifier: GPL-2.0 > > /* > > * Watchdog timer driver for the WinSystems EBC-C384 > > * Copyright (C) 2016 William Breathitt Gray > > * > >- * This program is free software; you can redistribute it and/or modify > >- * it under the terms of the GNU General Public License, version 2, as > >- * published by the Free Software Foundation. > >- * > >- * This program is distributed in the hope that it will be useful, but > >- * WITHOUT ANY WARRANTY; without even the implied warranty of > >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >- * General Public License for more details. > > */ > > #include > > #include Thank you for your feedback! >=20 > I have no problem with adding a SPDX line to the top of this file, but > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > with the selection of GPL version 2 only when I published this code. SPDX-License-Identifier: GPL-2.0 Is GPL-2.0 only [1], so it respects your choice of license. >=20 > Furthermore, please do not remove the existing copyright text; although The copyright text: Copyright (C) 2016 William Breathitt Gray Is still in the file. > it's just boilerplate for some, I was careful with the selection of > these words, and I worry the SPDX line only -- despite its useful > conciseness -- may lead to misunderstandings about my intentioned > license for this code. I'm not sure I understand your concerns here, the SPDX identifier is a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing = rules. One of the biggest benefits with SPDX identifier is that it is hard to veri= fy boiler plate licenses due to formatting, types, different formulations and = so on. If still worrying, I think we could keep the license text as well. >=20 > For the time being, I can't Ack this patch with the changes it makes > currently: >=20 > Nacked-by: William Breathitt Gray >=20 > William Breathitt Gray Please let me know if I got you wrong at some point. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /Documentation/process/license-rules.rst Best regards Marcus Folkesson --MZf7D3rAEoQgPanC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlqMILgACgkQiIBOb1ld UjK9Ag//RFYuvmLZSH6GnP5gGk0/GBMTVPPr95tPUKj2LxlQrPBqoWqCdFXnuHf1 da0hos+DEBo8xaRPtbvitCeWo3m3MgCG4RTCU/HKqTinyis52XV95y3YXGrMT6T9 kH/hukr9/oIIlKpz5bAIR9vfwo2hd2M1KkBsc5hYhloWY83jbuYTAEUcmogipLAu 5pPJIHWig0yHga6nTaUxwhyVShgX0qSiYfHihliemt+9reU5jtLDeDc3u5UrGiTg 6E2GeQYv9mA07s9xzWdHTAoyUx3sMCwAJ65F6u4E89uiQjVr7KFz7HvlMJswnehn xWqnN8L2fNNaUxxDrJ7aEwPy1dMbiVjxdOoIl9ivc4mDe+DpD6N0bxPEk6bj1hbR pMLtfoBZHQZok1lzvQk8B0EPvnfOEJsntjsb09R6io+28dU+z1KlZwFHZ7PJ4g0l lnb64yyNupUMsG7zRyAC8Hq5bJbFGf0aZMOHD/NuZul/2+k3cNuUJUVUqV2wndyk VduFlrBiDRk9mjFPnqlsnOgFVteAROyineIzMEeOPio05wMQ7/KJRKLxxL8TZNmw j6TtRSFPIZZTFmpR8Xu5Ezxm32qb/5umECl2WqPkauzEWL3erJxngioWLp2q7vTy 988Zz12kOcwGHl6N2F9FCbeoO4z8Bj9zSZMYezU/f3LR+SLaAy0= =96Xu -----END PGP SIGNATURE----- --MZf7D3rAEoQgPanC-- --===============3831320097026872127== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-mediatek mailing list Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-mediatek --===============3831320097026872127==--