From: Thierry Reding <thierry.reding@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical
Date: Mon, 12 Mar 2018 08:04:30 +0100 [thread overview]
Message-ID: <20180312070430.GA23060@ulmo> (raw)
In-Reply-To: <152061678678.13890.15810434310624804730@swboyd.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 2102 bytes --]
On Fri, Mar 09, 2018 at 09:33:06AM -0800, Stephen Boyd wrote:
> Quoting Thierry Reding (2018-03-08 06:44:37)
> > On Thu, Mar 01, 2018 at 04:33:29PM +0300, Dmitry Osipenko wrote:
> > > On 15.01.2018 13:56, Dmitry Osipenko wrote:
> > > > On 10.01.2018 16:59, Dmitry Osipenko wrote:
> > > >> Machine dies if HCLK, SCLK or EMC is disabled. Hence mark these clocks
> > > >> as critical.
> > > >>
> > > >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > > >> Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > > >> ---
> > > >>
> > > >> Change log:
> > > >> v2: Fixed accidentally missed marking EMC as critical on Tegra30 and
> > > >> Tegra124. Switched to a use of common EMC gate definition on Tegra20
> > > >> and Tegra30.
> > > >>
> > > >> v3: Dropped marking PLL_P outputs as critical, because seems they are
> > > >> not so critical. Although, I still haven't got a definitive answer
> > > >> about what exact HW functions are affected by the fixed-clocks.
> > > >> Anyway it should be cleaner to correct the actual drivers.
> > > >
> > > > Stephen / Michael, would it be possible to schedule these patches for 4.16? My
> > > > T20 and T30 devices aren't working without the 'critical clocks' patch. Things
> > > > happen to work with the opensource u-boot, but not with the proprietary
> > > > bootloader. It's probably not a big deal that out-of-tree devices are broken,
> > > > although would be nice to have one problem less.
> > >
> > > Guys, is there anything I could do to get these patches in linux-next?
> >
> > I've picked these up into the for-4.17/clk branch in the Tegra tree. I
> > already have that branch for the MBIST patches which are a dependency
> > for the for-4.17/soc branch.
> >
> > Stephen, Mike, let me know if you have any objections to carrying these
> > in the Tegra tree.
> >
>
> Are you going to send us a PR at some point?
Yes, I was going to let the patches cook a little in linux-next and send
a PR by the end of the week. Does that sound okay?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-12 7:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 13:59 [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical Dmitry Osipenko
2018-01-10 13:59 ` [PATCH v3 2/3] clk: tegra20: Correct PLL_C_OUT1 setup Dmitry Osipenko
2018-01-10 13:59 ` [PATCH v3 3/3] clk: tegra: Specify VDE clock rate Dmitry Osipenko
2018-01-15 10:56 ` [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical Dmitry Osipenko
2018-03-01 13:33 ` Dmitry Osipenko
2018-03-08 14:44 ` Thierry Reding
2018-03-09 14:35 ` Dmitry Osipenko
2018-03-12 7:15 ` Thierry Reding
2018-03-12 12:37 ` Dmitry Osipenko
2018-03-12 13:48 ` Thierry Reding
2018-03-09 17:33 ` Stephen Boyd
2018-03-12 7:04 ` Thierry Reding [this message]
2018-03-12 22:55 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312070430.GA23060@ulmo \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox