* [PATCH] mmc: tegra: remove redundant return statement
@ 2018-05-04 9:20 Aapo Vienamo
2018-05-04 9:27 ` Thierry Reding
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aapo Vienamo @ 2018-05-04 9:20 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson, Thierry Reding, Jonathan Hunter,
linux-mmc, linux-tegra, linux-kernel
A redundant return statement is removed from
tegra_sdhci_set_uhs_signaling(). The function returns void and the
return does not affect the control flow of the function.
Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
---
drivers/mmc/host/sdhci-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index b877c13184c2..970d38f68939 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
if (timing == MMC_TIMING_UHS_DDR50)
tegra_host->ddr_signaling = true;
- return sdhci_set_uhs_signaling(host, timing);
+ sdhci_set_uhs_signaling(host, timing);
}
static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: tegra: remove redundant return statement
2018-05-04 9:20 [PATCH] mmc: tegra: remove redundant return statement Aapo Vienamo
@ 2018-05-04 9:27 ` Thierry Reding
2018-05-04 9:50 ` Adrian Hunter
2018-05-08 9:06 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2018-05-04 9:27 UTC (permalink / raw)
To: Aapo Vienamo
Cc: Adrian Hunter, Ulf Hansson, Jonathan Hunter, linux-mmc,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On Fri, May 04, 2018 at 12:20:53PM +0300, Aapo Vienamo wrote:
> A redundant return statement is removed from
> tegra_sdhci_set_uhs_signaling(). The function returns void and the
> return does not affect the control flow of the function.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..970d38f68939 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
> if (timing == MMC_TIMING_UHS_DDR50)
> tegra_host->ddr_signaling = true;
>
> - return sdhci_set_uhs_signaling(host, timing);
> + sdhci_set_uhs_signaling(host, timing);
> }
>
> static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
Good catch!
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: tegra: remove redundant return statement
2018-05-04 9:20 [PATCH] mmc: tegra: remove redundant return statement Aapo Vienamo
2018-05-04 9:27 ` Thierry Reding
@ 2018-05-04 9:50 ` Adrian Hunter
2018-05-08 9:06 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Hunter @ 2018-05-04 9:50 UTC (permalink / raw)
To: Aapo Vienamo, Ulf Hansson, Thierry Reding, Jonathan Hunter,
linux-mmc, linux-tegra, linux-kernel
On 04/05/18 12:20, Aapo Vienamo wrote:
> A redundant return statement is removed from
> tegra_sdhci_set_uhs_signaling(). The function returns void and the
> return does not affect the control flow of the function.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..970d38f68939 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
> if (timing == MMC_TIMING_UHS_DDR50)
> tegra_host->ddr_signaling = true;
>
> - return sdhci_set_uhs_signaling(host, timing);
> + sdhci_set_uhs_signaling(host, timing);
> }
>
> static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: tegra: remove redundant return statement
2018-05-04 9:20 [PATCH] mmc: tegra: remove redundant return statement Aapo Vienamo
2018-05-04 9:27 ` Thierry Reding
2018-05-04 9:50 ` Adrian Hunter
@ 2018-05-08 9:06 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2018-05-08 9:06 UTC (permalink / raw)
To: Aapo Vienamo
Cc: Adrian Hunter, Thierry Reding, Jonathan Hunter,
linux-mmc@vger.kernel.org, linux-tegra, Linux Kernel Mailing List
On 4 May 2018 at 11:20, Aapo Vienamo <aapo.vienamo@iki.fi> wrote:
> A redundant return statement is removed from
> tegra_sdhci_set_uhs_signaling(). The function returns void and the
> return does not affect the control flow of the function.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..970d38f68939 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
> if (timing == MMC_TIMING_UHS_DDR50)
> tegra_host->ddr_signaling = true;
>
> - return sdhci_set_uhs_signaling(host, timing);
> + sdhci_set_uhs_signaling(host, timing);
> }
>
> static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
> --
> 2.16.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-08 9:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-04 9:20 [PATCH] mmc: tegra: remove redundant return statement Aapo Vienamo
2018-05-04 9:27 ` Thierry Reding
2018-05-04 9:50 ` Adrian Hunter
2018-05-08 9:06 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox