From: Thierry Reding <thierry.reding@gmail.com>
To: Aapo Vienamo <aapo.vienamo@iki.fi>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: tegra: remove redundant return statement
Date: Fri, 4 May 2018 11:27:16 +0200 [thread overview]
Message-ID: <20180504092716.GA13459@ulmo> (raw)
In-Reply-To: <20180504092053.GA20277@orion>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On Fri, May 04, 2018 at 12:20:53PM +0300, Aapo Vienamo wrote:
> A redundant return statement is removed from
> tegra_sdhci_set_uhs_signaling(). The function returns void and the
> return does not affect the control flow of the function.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..970d38f68939 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
> if (timing == MMC_TIMING_UHS_DDR50)
> tegra_host->ddr_signaling = true;
>
> - return sdhci_set_uhs_signaling(host, timing);
> + sdhci_set_uhs_signaling(host, timing);
> }
>
> static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
Good catch!
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-04 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 9:20 [PATCH] mmc: tegra: remove redundant return statement Aapo Vienamo
2018-05-04 9:27 ` Thierry Reding [this message]
2018-05-04 9:50 ` Adrian Hunter
2018-05-08 9:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504092716.GA13459@ulmo \
--to=thierry.reding@gmail.com \
--cc=aapo.vienamo@iki.fi \
--cc=adrian.hunter@intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox