From: Mark Brown <broonie@kernel.org>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>
Subject: Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting
Date: Sat, 21 Jul 2018 10:56:15 +0100 [thread overview]
Message-ID: <20180721095615.GG16228@sirena.org.uk> (raw)
In-Reply-To: <1532089865.19673.13.camel@toradex.com>
[-- Attachment #1.1: Type: text/plain, Size: 903 bytes --]
On Fri, Jul 20, 2018 at 12:31:07PM +0000, Marcel Ziswiler wrote:
> On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote:
> > > ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> > > "nvidia,codec-sync-
> > > gpio", 0);
> > > if (!gpio_is_valid(ac97->sync_gpio)) {
> > > - dev_err(&pdev->dev, "no codec-sync GPIO
> > > supplied\n");
> > > + ret = ac97->sync_gpio;
> > > + dev_err(&pdev->dev, "no codec-sync GPIO supplied:
> > > %d\n", ret);
> > > goto err_clk_put;
> > > }
> > This isn't reporting an error code associated with the attempt to
> > find a
> > codec-sync GPIO, it's the result of some other operation.
> What exactly is then the of_get_named_gpio() above please doing if
> not getting the codec sync GPIO? I am not following you, sorry.
It's not in any way involved in setting the value of ret, whatever value
that has it's nothing to do with that operation.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-07-21 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 8:04 [PATCH 1/2] ASoC: tegra: improve goto error label Marcel Ziswiler
2018-07-20 8:04 ` [PATCH 2/2] ASoC: tegra: probe deferral error reporting Marcel Ziswiler
2018-07-20 12:16 ` Mark Brown
2018-07-20 12:31 ` Marcel Ziswiler
2018-07-21 9:56 ` Mark Brown [this message]
2018-07-21 10:06 ` Marcel Ziswiler
2018-07-23 10:25 ` Mark Brown
2018-07-21 11:17 ` Dmitry Osipenko
2018-07-21 11:55 ` Marcel Ziswiler
2018-07-21 12:03 ` Dmitry Osipenko
2018-07-21 12:15 ` Dmitry Osipenko
2018-07-26 8:34 ` Stefan Agner
2018-07-20 12:19 ` Applied "ASoC: tegra: improve goto error label" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721095615.GG16228@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox